Error in the PHP side code

Question

0.00/5 (No votes)

See more:

I v tried simple form using bootstrap..
entry is done in database when u submit the form..
but the error is generated line 5 to 13..
i defined the values in sql still the error is runing

What I have tried:

PHP

<?php 
require('../../../Connections/cn.php');
if(isset($_POST['submit']));
{
	$name=$_POST['name'];
	$middlename=$_POST['middlename'];
	$surname=$_POST['surname'];
	$karykarnum=$_POST['karykarnum'];
	$bday=$_POST['bday'];
	$email=$_POST['email'];
	$mobile=$_POST['mobile'];
	$address=$_POST['address'];
	$city=$_POST['city'];
	
	$query="INSERT INTO own_details(name, middlename, surname, karykarnum, bday, email, mobile, address, city) VALUES ('$name', '$middlename', '$surname', '$karykarnum', '$bday', '$email', '$mobile', '$address', '$city')";
	$result=mysql_query($query);
	
	
	}
?>

<!DOCTYPE html>



  <!-- Required meta tags -->
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
  <title>Star Admin Free Bootstrap-4 Admin Dashboard Template
  <!-- plugins:css -->
      <!-- endinject -->
  <!-- plugin css for this page -->
  <!-- End plugin css for this page -->
  <!-- inject:css -->
    <!-- endinject -->
  


  <div class="container-scroller">
    <!-- partial:../../partials/_navbar.html -->
    
      <div class="text-center navbar-brand-wrapper d-flex align-items-top justify-content-center">
        <a class="navbar-brand brand-logo" href="../../index.html"></a>
        <a class="navbar-brand brand-logo-mini" href="../../index.html"></a>
      </div>
      <div class="navbar-menu-wrapper d-flex align-items-center">
        <ul class="navbar-nav navbar-nav-left header-links d-none d-md-flex">
          <li class="nav-item">            <a href="#" class="nav-link"></a>
          </li>          <li class="nav-item">            <a href="#" class="nav-link">^__i class="mdi mdi-calendar"__^</i__^Calendar</a>
          </li>        </ul>
        <ul class="navbar-nav navbar-nav-right">
          <li class="nav-item dropdown">            <a class="nav-link count-indicator dropdown-toggle" id="notificationDropdown" href="#">
              ^__i class="mdi mdi-bell-ring"__^
              <span class="count">4</span>
            </a>
            <div class="dropdown-menu dropdown-menu-right navbar-dropdown preview-list">
              <a class="dropdown-item">
                <p class="mb-0 font-weight-normal float-left">You have 4 new notifications
                </p>
                <span class="badge badge-pill badge-warning float-right">View all</span>
              </a>
              <div class="dropdown-divider"></div>
              <a class="dropdown-item preview-item">
                <div class="preview-thumbnail">
                  <div class="preview-icon bg-success">
                    ^__i class="icon-info mx-0"__^
                  </div>
                </div>
                <div class="preview-item-content">
                  <h6 class="preview-subject font-weight-medium">Application Error</h6>
                  <p class="font-weight-light small-text">
                    Just now
                  </p>
                </div>
              </a>
              <div class="dropdown-divider"></div>
              <a class="dropdown-item preview-item">
                <div class="preview-thumbnail">
                  <div class="preview-icon bg-warning">
                    ^__i class="icon-speech mx-0">
                  </div>
                </div>
                <div class="preview-item-content">
                  <h6 class="preview-subject font-weight-medium">Settings</h6>
                  <p class="font-weight-light small-text">
                    Private message
                  </p>
                </div>
              </a>
              <div class="dropdown-divider"></div>
              <a class="dropdown-item preview-item">
                <div class="preview-thumbnail">
                  <div class="preview-icon bg-info">
                    ^__i class="icon-envelope mx-0">
                  </div>
                </div>
                <div class="preview-item-content">
                  <h6 class="preview-subject font-weight-medium">New user registration</h6>
                  <p class="font-weight-light small-text">
                    2 days ago
                  </p>
                </div>
              </a>
            </div>
          </li>          <li class="nav-item dropdown">            <a class="nav-link count-indicator dropdown-toggle" id="messageDropdown" href="#">
              ^__i class="mdi mdi-email-variant">
              <span class="count">7</span>
            </a>
            <div class="dropdown-menu dropdown-menu-right navbar-dropdown preview-list">
              <div class="dropdown-item">
                <p class="mb-0 font-weight-normal float-left">You have 7 unread mails
                </p>
                <span class="badge badge-info badge-pill float-right">View all</span>
              </div>
              <div class="dropdown-divider"></div>
              <a class="dropdown-item preview-item">
                <div class="preview-thumbnail">
                  
                </div>
                <div class="preview-item-content flex-grow">
                  <h6 class="preview-subject ellipsis font-weight-medium">David Grey
                    <span class="float-right font-weight-light small-text">1 Minutes ago</span>
                  </h6>
                  <p class="font-weight-light small-text">
                    The meeting is cancelled
                  </p>
                </div>
              </a>
              <div class="dropdown-divider"></div>
              <a class="dropdown-item preview-item">
                <div class="preview-thumbnail">
                  
                </div>
                <div class="preview-item-content flex-grow">
                  <h6 class="preview-subject ellipsis font-weight-medium">Tim Cook
                    <span class="float-right font-weight-light small-text">15 Minutes ago</span>
                  </h6>
                  <p class="font-weight-light small-text">
                    New product launch
                  </p>
                </div>
              </a>
              <div class="dropdown-divider"></div>
              <a class="dropdown-item preview-item">
                <div class="preview-thumbnail">
                  
                </div>
                <div class="preview-item-content flex-grow">
                  <h6 class="preview-subject ellipsis font-weight-medium"> Johnson
                    <span class="float-right font-weight-light small-text">18 Minutes ago</span>
                  </h6>
                  <p class="font-weight-light small-text">
                    Upcoming board meeting
                  </p>
                </div>
              </a>
            </div>
          </li>          <li class="nav-item d-none d-lg-block">            <a class="nav-link" href="#">
              
            </a>
          </li>        </ul>
        
          <span class="icon-menu"></span>
        
      </div>
    
    <!-- partial -->
    <div class="container-fluid page-body-wrapper">
      <!-- partial:../../partials/_sidebar.html -->
      
        <ul class="nav">
          <li class="nav-item nav-profile">            <div class="nav-link">
              <div class="profile-image">  <span class="online-status online"></span> </div>
              <div class="profile-name">
                <p class="name">Richard V.Welsh</p>
                <p class="designation">Manager</p>
                <div class="badge badge-teal mx-auto mt-3">Online</div>
              </div>
            </div>
          </li>          
          <li class="nav-item"><a class="nav-link" href="1details.php"><span class="menu-title">My Own Deatils</span></a></li>          <li class="nav-item"><a class="nav-link" href="2details.php"><span class="menu-title">Karykar Details</span></a></li>         
      </ul>
      <!-- partial -->
      <div class="main-panel">
        <div class="content-wrapper">
          <div class="row">
            <div class="col-md-6 d-flex align-items-stretch grid-margin">
              <div class="row flex-grow">
                <div class="col-12">
                  <div class="card">
                    <div class="card-body">
                      <h4 class="card-title">My Own Details</h4>
                      
                      <div class="form-group">
                          Name
                          
                        </div>
                        <div class="form-group">
                          Middle Name
                          
                        </div>
                        <div class="form-group">
                          Surname
                          
                        </div>
                        <div class="form-group">
                          Karyakar Number
                          
                        </div>
                        <div class="form-group">
                          Birth day
                          
                        </div>
                        <div class="form-group">
                          Email address
                          
                        </div>
                        <div class="form-group">
                          Mobile Num
                          
                        </div>
                        <div class="form-group">
                          Address
                          
                        </div>
                        <div class="form-group">
                          City
                          
    									Anand
                                        V.V.Nagar
                                        Mogri
                                        Gana
                                        Jitodiya
                                        Karamsad
                                                             
                                       </div>
                        
                      
                    </div>
                  </div>
                </div>
                 <!-- content-wrapper ends -->
        <!-- partial:../../partials/_footer.html -->
        
          <div class="container-fluid clearfix">
            <span class="text-muted d-block text-center text-sm-left d-sm-inline-block">Copyright © 2018 <a href="http://www.bootstrapdash.com/" target="_blank">Bootstrapdash</a>. All rights reserved.</span>
            <span class="float-none float-sm-right d-block mt-1 mt-sm-0 text-center">Hand-crafted & made with ^__i class="mdi mdi-heart text-danger"></span>
          </div>
        
        <!-- partial -->
      </div>
      <!-- main-panel ends -->
    </div>
    <!-- page-body-wrapper ends -->
  </div></div></div></div></div>

Jochen Arndt · Answer 1 · 2018-05-13T21:11:00

You have not posted the error messages but I guess it is about non existing indexes when executing the code without POST data.

The source of the problem is in the previous line

PHP

if(isset($_POST['submit']));

There is a trailing semicolon which makes the if condition a single (terminated) statement so that the statements in the following block are always executed.

The above line should be

PHP

if(isset($_POST['submit']))

Patrice T · Answer 2 · 2018-05-13T23:57:00

PHP

$query="INSERT INTO own_details(name, middlename, surname, karykarnum, bday, email, mobile, address, city) VALUES ('$name', '$middlename', '$surname', '$karykarnum', '$bday', '$email', '$mobile', '$address', '$city')";

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]

Error in the PHP side code

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Error in the PHP side code

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us