How can I help display better with SQL PHP code?

Question

0.00/5 (No votes)

See more:

Hi See my code below,
My code seems to be working okay .. but it just seems like a lot of copy and paste code to suit to each food.

I am currently displaying meals in relation to 'keywords' in which were given to a user, which they were able to select which ones they prefer. Basically, what it's doing is displaying meals based on their preferences(which they completed via a checkbox form)

If anyone can help me out here that would be really much appreciated.

What I have tried:

include ("dbConnect.php");
$1 = ("cheese");
$2 = ("yoghurt");
$3 = ("egg");
$4 = ("fruit");
$5 = ("cereal");
$6 = ("oatmeal");
	
   $dbQuery=$conn->prepare("select * from FoodQuestionnaireResults where UserID=$UserID");
   $dbQuery=$conn->prepare("select * from Recipes where Keyword = '$1'");
   $dbQuery->execute();
   while ($dbRow=$dbQuery->fetch(PDO::FETCH_ASSOC)) {
if ($B1 = '1') {
  echo "<br><br><h4>".$dbRow["Name"]."</h4><br>"."<br><img src=Breakfast/".$dbRow['Picture']."' width='150' height='150' />"."<br><br>".$dbRow["Instructions"].";
} else {
    echo "";
}
   $dbQuery=$conn->prepare("select * from Recipes where Keyword = '$2'");
   $dbQuery->execute();
   while ($dbRow=$dbQuery->fetch(PDO::FETCH_ASSOC)) {
if ($B2 = '1') {
  echo "<br><br><h4>".$dbRow["Name"]."</h4><br>"."<br><img src=Breakfast/".$dbRow['Picture']."' width='150' height='150' />"."<br><br>".$dbRow["Instructions"].";
} else {
    echo "";
}
   }
   }
?>

Posted 23-Mar-18 4:32am

Member 13637584

Updated 23-Mar-18 21:38pm

Add a Solution

Comments

CHill60 23-Mar-18 14:53pm

What is the actual problem? Why would you cut and paste for each food? Use an array perhaps? PHP: Arrays - Manual[^] or a collection? PHP: Collection - Manual[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

enhzflep · Answer 1 · 2018-03-23T21:39:00

I suspect you'll find that if ($B1 = '1') doesn't do what you think it does. Hint: In javascript, = is the assignment operator, == is the check-for-equality operator. ;)
SQL unfortunately, uses a single = to check for equality - this confuses many new users when they must use different operators in different languages to perform the same task.

Here's how I'd go about it.

<?php
$userName = 'root';
$password = '';
$pdo = new PDO('mysql:host=localhost', $userName, $password);
$pdo->query("use testjobsdb");
	
$materials = Array("10A GPO Triple","10A GPO Double","10A GPO Single","10A GPO Double W/extra");
$stmt = $pdo->prepare("select * from Materials where name = :someStockItem");

forEach($materials as $curMaterial)
{
	$stmt->bindParam(":someStockItem", $curMaterial);
	$stmt->execute();
	while ( $dbRow = $stmt->fetch(PDO::FETCH_ASSOC) )
	{
		echo "<h4>".$dbRow["id"]."</h4><br>" . $dbRow['name'] . "<br>";
	}
}
?>