Click here to Skip to main content
15,890,690 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
Dim da As New SqlDataAdapter

da.InsertCommand = cmd
da.InsertCommand.ExecuteNonQuery() 'Here i m geeting error

What I have tried:

i want solution of this

i m inserting data in database and getting error
Posted
Updated 4-Jan-18 6:31am
Comments
Karthik_Mahalingam 4-Jan-18 22:57pm    
post the relevant code
Use Improve question to add edit the question.

1 solution

Look at the error message:
Failed to convert parameter value from a string to a int32 

It's saying "I expected an integer here, and you gave me a string that doesn't contain an integer value."

So look at cmd using the debugger and see exactly what you are passing as the command - and since that code doesn't use parameters, the chances are that your code is wide open to SQL Injection.
Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900