How to save all the entered label value in label using SQL in C# ASP.NET

Question

1.00/5 (1 vote)

See more:

I want to have all the entered label to be display in label.

What I have tried:

SqlConnection con   = new SqlConnection(@"Data Source = My-pc\Sqlexpress; Integrated Security = SSPI; user = Sa; Password = 
            SqlCommand cmd = new SqlCommand("Insert Into EnterMessage (Message) Values ('" + lblEnterMessage.Text + "', '" + txtMessage.Text + "','");
            con.Open();
            cmd.Parameters.AddWithValue("EnterMessage", txtMessage.Text);
            cmd.ExecuteNonQuery();
            SqlDataAdapter sda = new SqlDataAdapter();
            SqlDataReader reader = cmd.ExecuteReader();
            con.Close();

Posted 15-Dec-17 9:28am

Member 13572556

Updated 18-Dec-17 6:54am

v2

Add a Solution

Comments

Richard Deeming 18-Dec-17 13:38pm

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

2 solutions

Solution 2

SqlConnection con   = new SqlConnection(@"Data Source = My-pc\Sqlexpress; Integrated Security = SSPI; user = Sa; Password = 
            SqlCommand cmd = new SqlCommand("Insert Into EnterMessage (Message) Values ('"  + txtMessage.Text + "'");
            con.Open();
           
            cmd.ExecuteNonQuery();
            
            con.Close();

Posted 18-Dec-17 6:53am

Laxmidhar tatwa technologies

Comments

Richard Deeming 18-Dec-17 13:38pm

You have copied the SQL Injection[^] vulnerability from the question.

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2017-12-15T09:56:00

If you're asking how to insert multiple textbox entries, you have to insert them one at a time. SQL doesn't understand that the comma you put in there is another entry to insert into it's own record.

Oh, and using the SA account is a really bad idea. Thanks for the password too.

That account gives the application access to do ANYTHING to the database, even destroy it. You might want to Google for "SQL Injection Attack" to find out why what you're doing is so bad and then Google for "C# parameterize queries" to find out what to do about it.