Localstorage not saving variable on refresh javascript

Question

0.00/5 (No votes)

See more:

Hello!I am creating a coins variable where you can buy pokemon. Each time you buy pokemon, the coins variable will be depleted. How do I make it to where LocalStorage saves my code? I have already tried this code:

function buymagikarp() {
  if(coins >= 100 ) {
    swal("Success", "You bought 1 magikarp!", "success");
    coins -= 100;
    pokemonchosen.push("Magikarp");
    document.getElementById("p1").innerHTML = "Coins: " + coins; 
    coins = localStorage.getItem('coins');
  } else {
    swal("Error", "Not enough balance", "error");
  }
}

What I have tried:

function buymagikarp() {
  if(coins >= 100 ) {
    swal("Success", "You bought 1 magikarp!", "success");
    coins -= 100;
    pokemonchosen.push("Magikarp");
    document.getElementById("p1").innerHTML = "Coins: " + coins; 
    coins = localStorage.getItem('coins');
  } else {
    swal("Error", "Not enough balance", "error");
  }
}

Posted 1-Aug-17 12:21pm

Member 13257242

Updated 1-Aug-17 19:10pm

Add a Solution

Comments

Afzaal Ahmad Zeeshan 1-Aug-17 19:09pm

Where are those objects coming from? pokemonchosen? You are also not setting the object at all, so how would JavaScript know what to do?

Member 13257242 2-Aug-17 13:41pm

I omitted code from the question that I thought was not needed.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2017-08-01T19:10:00

Solution 1

You have this line of code:

JavaScript

coins = localStorage.getItem('coins');

You don't want this line. What it does, is overwriting coins after coins -= 100 with the old value from localStorage. You probably want this instead of getItem:

JavaScript

localStorage.setItem('coins', coins);

Posted 1-Aug-17 19:10pm

Thomas Daniels