Create an array with user's input

Question

1.00/5 (1 vote)

See more:

I want to create a loop that only last until the right input is given by the user.
Requriments are:
The number should be between 1 t0 100 and the number entered should not be same as previous.

What I have tried:

C#

for (int i = 0; i < Number.Length; i++)
{
Console.WriteLine("Enter number 1. The number must be between 1-100");
Number[i] = Int32.Parse(Console.ReadLine());

    if (Number[i] < 1)
    {
        Console.WriteLine("Please reenter number. The number must be between 1-100");
    }

    else if (Number[i] > 100)
    {
        Console.WriteLine("Please reenter number 1. The number must be between 1-100");
    }
    else
    {
       //store the value in the array
        Number[i] = Number[i];
    }


}

for (int i = 0; i < Number.Length; i++)
{

    Console.WriteLine("Enter number 2. The number must be between 1-100");
    Number[i] = Int32.Parse(Console.ReadLine());

    if (Number[i] < 1)
    {
        Console.WriteLine("Number less than 1. Please reenter number 2.
The number must be between 100");
    }
    else if (Number[i] > 100)
    {
        Console.WriteLine("Please reenter number 2. The number must be between 1-100");
    }
    else if (Number[i] == Number[i])
    {
        Console.WriteLine("Numbers must be unique. It cannot match any of the pervisouly entered numbers");
    }
    else
    {
        Number[i] = Number[i];
    }
}

for (int i = 0; i < Number.Length; i++)
{
    Console.WriteLine("Enter number 3. The number must be between 1-100");
    Number[i] = Int32.Parse(Console.ReadLine());

    if (Number[i] < 1)
    {
        Console.WriteLine("Please reenter number 3. The number must be between 1-100");
    }
    else if (Number[i] > 100)
    {
        Console.WriteLine("Please reenter number 3. The number must be between 1-100");
    }
    else if (Number[i] == Number[i])
    {
        Console.WriteLine("Numbers must be unique. It cannot match any of the pervisouly entered numbers");
    }
    else
    {
        Number[i] = Number[i];
    }

Posted 19-Apr-17 14:31pm

Member 12984155

Updated 19-Apr-17 21:30pm

User 4180254

v2

Add a Solution

Comments

Bhola Ram Sahu 19-Apr-17 20:44pm

||else if (Number[i] == Number[i])|| This condition will always true. Thats why you are not getting correct result.

Use inner loop or a function to check duplicate value.

[no name] 19-Apr-17 21:04pm

And your question is what?
What happens when the user inputs "A"?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tomas Takac · Accepted Answer · 2017-04-19T21:30:00

Your logic is overly complicated. You can do all in one loop. Also you need to learn to encapsulate logic into methods/functions/classes in order to reuse code and make it more readable.

C#

for (int i = 0; i < Number.Length; i++)
{
    while (true) // loop until you have correct number
    {
        var number = ReadNumber();
        if (IsValid(number))
        {
            Number[i] = number; // store if it's correct
            break; // exit the inner while-loop as we have correct number
        }
    }
}

int ReadNumber()
{
    Console.WriteLine("Enter number 1. The number must be between 1-100");
    return Int32.Parse(Console.ReadLine());
}

bool IsValid(int number)
{
    if (number < 1)
    {
        Console.WriteLine("Please reenter number. The number must be between 1-100");
        return false;
    }
    if (number > 100)
    {
        Console.WriteLine("Please reenter number. The number must be between 1-100");
        return false;
    }
    return true;
}

I didn't run this through compiler so there may be typos. I also didn't include uniqueness check on purpose. Try to figure that on your own as this is another exercise in encapsulation.