Text not saving in my database?

Question

1.00/5 (2 votes)

See more:

Each time when I press my button it says

An unhandled exception of type 'System.Data.SqlClient.SqlException' occurred in System.Data.dll
Additional information: Incorrect syntax near the keyword 'DataBase'.

Incorrect syntax near the keyword 'SET'.

Could you help me?

What I have tried:

private void button1_Click(object sender, EventArgs e)
{
  con = new SqlConnection(@"Data Source=        (LocalDB)\MSSQLLocalDB;AttachDbFilename=C:\Users\djino_5yu1pcr\Documents\DataSet.mdf;I  ntegrated Security=True;Connect Timeout=30");
  con.Open();
  cmd = new SqlCommand("Update DataBase Set (Serial,Name) VALUES (@Serial,@Name)", con);
  cmd.Parameters.Add("@Serial", txtSerial.Text);
  cmd.Parameters.Add("@Name", txtName.Text);
  cmd.ExecuteNonQuery();
}

Posted 3-Jan-17 4:22am

Member 12932743

Updated 3-Jan-17 4:41am

David_Wimbley

v2

Add a Solution

Comments

[no name] 3-Jan-17 10:24am

http://www.w3schools.com/sql/sql_update.asp

Member 12932743 3-Jan-17 10:27am

Can you use Insert and into?

[no name] 3-Jan-17 14:37pm

Did you try?

2 solutions

Solution 1

You've made an UPSERT statement (which isn't a thing that exists). Your UPDATE statement is wrong...it looks like you mixed the formatting of INSERT and UPDATE. It should be formatted as follows

SQL

UPDATE Database SET Serial = @Serial, Name = @Name;

So that would be

UPDATE <TableName> SET <ColumnName> = <ColumnValue>,<ColumnName> = <ColumnValue>

or for single column updates

UPDATE <TableName> SET <ColumnName> = <ColumnValue>

Posted 3-Jan-17 4:32am

David_Wimbley

Updated 3-Jan-17 4:34am

v2

Comments

Member 12932743 3-Jan-17 10:36am

I tried the insert method but it said Additional information: Incorrect syntax near the keyword 'DataBase'.

David_Wimbley 3-Jan-17 10:40am

That is fine, but based on the code sample you provided in your question the way you've formatted that UPDATE is not correct syntax. My answer provides you correct syntax.

Also to be clear, you can't update a database, you have to specify the table within the database to update.

So assuming you are using SQL Server if you have a database called Company and a table called Employees...if you are trying to update the Employees table you can't do

UPDATE Company SET Name = 'David' WHERE Id = 1

you have specify the table such as

UPDATE Employees SET Name = 'David' WHERE id = 1

. You can specify the database if you wish but that should be specified in your connection string.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

PeejayAdams · Accepted Answer · 2017-01-03T04:41:00

Assuming that you are trying to update a table called DataBase, there are two problems:

1) Your UPDATE command syntax is wrong (See the link provided by NPC in the comments).

2) Database is a reserved word in SQL. It's okay to use reserved words as object names but you'll need to escape them with square brackets when you refer to them.

As such, your SQL should look like this:

SQL

UPDATE [DataBase] SET Serial = @Serial, Name = @Name

Note that that will update every row in the table as there is no WHERE clause.