How to ensure the correct return values from a stored procedure.

Question

4.56/5 (2 votes)

See more:

I have created a table called 'Names' in SQL with the following 2 columns

ID	AUTO ID
NAME	AS nVarchar(MAX)

I have a stored procedure to add Name in it if that name doesn't exist already as

SQL

CREATE PROCEDURE [dbo].[Ins_NameNew] 
(
	@Name_Input	varChar(Max)
)
AS 
BEGIN
	DECLARE @NameExist INT
	DECLARE @NameID INT
	DECLARE @Action NVARCHAR(5)
	
	-- Check if the name exists
	SET @NameExist =
			CASE
				WHEN EXISTS (SELECT * FROM [dBName].[dbo].[Names] WHERE Name = @Name_Input )
				THEN 1
				ELSE 0
			END
	
	-- Proceed with Insert if doesn't exist
	IF @NameExist = 0

	BEGIN
			INSERT INTO [dBName].[dbo].[Names]
			(Name)
			VALUES
				(@Name_Input);
	END
	
	-- Get the ID whether Name existed already or just added	
	SET @NameID = (SELECT ID FROM [dBName].[dbo].[Names] WHERE Name = @Name_Input)
	
	
	SET @Action =
		CASE
			WHEN @NameExist = 0
			THEN 'Added'
			ELSE 'Exist'
		END

	SELECT @NameExist, @NameID, @Action
END

This works fine when it comes to adding the new name. But each time it returns @NameExist as 1 and @Action as 'Exist'

Any suggestions where I am going wrong with the stored proc.

What I have tried:

SQL

CREATE PROCEDURE [dbo].[Ins_NameNew] 
(
	@Name_Input	varChar(Max)
)
AS 
BEGIN
	DECLARE @NameExist INT
	DECLARE @NameID INT
	DECLARE @Action NVARCHAR(5)
	
	-- Check if the name exists
	SET @NameExist =
			CASE
				WHEN EXISTS (SELECT * FROM [dBName].[dbo].[Names] WHERE Name = @Name_Input )
				THEN 1
				ELSE 0
			END
	
	-- Proceed with Insert if doesn&#39;t exist
	IF @NameExist = 0

	BEGIN
			INSERT INTO [dBName].[dbo].[Names]
			(Name)
			VALUES
				(@Name_Input);
	END
	
	-- Get the ID whether Name existed already or just added	
	SET @NameID = (SELECT ID FROM [dBName].[dbo].[Names] WHERE Name = @Name_Input)
	
	
	SET @Action =
		CASE
			WHEN @NameExist = 0
			THEN 'Added'
			ELSE 'Exist'
		END

	SELECT @NameExist, @NameID, @Action
END

Posted 7-Nov-16 5:56am

DinoOnCodeProject

Updated 17-Nov-16 12:35pm

PIEBALDconsult

v3

Add a Solution

Comments

DinoOnCodeProject 7-Nov-16 11:59am

Kindly excuse the grammatical errors like ' as I am very new to this site and slowly learning how to post questions. Hope the question doesn't sound too confusing due to this. I can see that it is replacing ' with '. Will be more careful next time.
Thanks in advance.

DinoOnCodeProject 7-Nov-16 12:21pm

Thanks @PIEBALDconsult for correcting me. :)

Herman<T>.Instance 8-Nov-16 7:28am

Hint: UPSERT

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Lolo1986 · Accepted Answer · 2016-11-17T12:35:00

Hello,

Seems that your ID is an Identity column, you could easily simply your code by doing something like this.

SQL

CREATE PROCEDURE [dbo].[Ins_NameNew] 
(
	@Name_Input	varChar(Max)
)
AS 
BEGIN
	DECLARE @NameExist INT = 0
	DECLARE @NameID INT

	-- Proceed with Insert if doesn't exist
	IF EXISTS (SELECT * FROM [dBName].[dbo].[Names] WHERE Name = @Name_Input)
	BEGIN
			INSERT INTO [dBName].[dbo].[Names]
			(Name)
			VALUES
				(@Name_Input);
                       SET @NameID = @@IDENTITY;
	END
	ELSE
        BEGIN
                -- Get the ID whether Name existed already or just added, )
                -- remove top 1 if you Name is unique
	       SET @NameID = (SELECT TOP 1 ID FROM [dBName].[dbo].[Names] WHERE Name = @Name_Input)
                SET @NameExist = 1;
        END

 
	SELECT @NameExist, 
                      @NameID, 
                CASE
			WHEN @NameExist = 0
			THEN 'Added'
			ELSE 'Exist'
		END as 'Action'
END