login problem (Web Application)

Question

5.00/5 (1 vote)

See more:

using System;
using System.Collections;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.HtmlControls;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Xml.Linq;
using System.Data.OleDb; //connecting database

public partial class LawyersHome : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        
        string a = Request.Form["uname"].ToString();
        string b = Request.Form["pwd"].ToString();
        OleDbConnection con = new OleDbConnection();
        con.ConnectionString = @"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=H:\MoratuwaLawyersAssociation\MLADB.mdb";
        con.Open();
        string sql = "SELECT * FROM admin";
        OleDbCommand comm = new OleDbCommand(sql, con);
        OleDbDataReader or;
        or = comm.ExecuteReader();
        while (or.Read())
        {
            if ((a == or["aID"].ToString()) && (b == or["apw"].ToString()))
            {
                con.Close();
                Response.Redirect("LawyersHome.aspx");
            }
            else
            {
                con.Close();
                Response.Redirect("IncorrectLogin.aspx");
            }
        }
        


    }
}

even though i enter a correct password it re direct into wrong page can anybody help me to overcome this.

Posted 20-Sep-10 2:11am

Strider1987

Updated 20-Sep-10 2:15am

Goutam Patra

v2

Add a Solution

5 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Toniyo Jackson · Answer 1 · 2010-09-20T02:16:00

Solution 1

may be space is there in username and password. so use trim

if ((a == or["aID"].ToString().trim) && (b == or["apw"].ToString().trim))

Posted 20-Sep-10 2:16am

Toniyo Jackson

Comments

Strider1987 20-Sep-10 8:51am

This works only once when i try second it doesn't. i think there s something wrong inside my code. ty for ur support

Goutam Patra · Answer 2 · 2010-09-20T02:20:00

How many records you have in your admin table?
Debug your application and you will find the disaster you have made. If the first record does not match with your username and password it will redirect to the “wrong page”.
Select the only for the username and password specified using where condition and then check whether any records fetched or not. If fetched then redirect to success page, error page otherwise. That will solve your problem.

sureshbalachander · Answer 3 · 2010-09-20T02:28:00

Hi,

There is a logic issue in your code.

First say, your admin table contains following records
sno aID aPW

1 ID1 PW1
2 ID2 PW2
3 ID3 PW3

As per your code logic, if i give ID2 and PW2, the WHILE loop will check the database and fetches the first record ID1 and PW1 and it fails the IF condition and goes to ELSE part and closses connection and redirects to the Web page in ELSE part.

Here modified your code, see below,

protected void Page_Load(object sender, EventArgs e)
{
string a = Request.Form["uname"].ToString();
string b = Request.Form["pwd"].ToString();
OleDbConnection con = new OleDbConnection();
con.ConnectionString = @"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=H:\MoratuwaLawyersAssociation\MLADB.mdb";
con.Open();
string sql = "SELECT * FROM admin";
OleDbCommand comm = new OleDbCommand(sql, con);
OleDbDataReader or;
or = comm.ExecuteReader();
bool isFound = false;
while (or.Read())
{
if ((a == or["aID"].ToString()) && (b == or["apw"].ToString()))
{
  isFound = true;
  break;
}
else
{
  isFound = false;
}
}

con.close();

if(isFound)
{
  Response.Redirect("LawyersHome.aspx");
}
else
{
  Response.Redirect("IncorrectLogin.aspx");
}

}

NOTE: You are using Openconnection method. It takes time to load your data. Try using Closed connection method. That will speed up your process.

Regards,
Suresh

velmahesh · Answer 4 · 2011-01-07T20:42:00

Solution 4

check the condition. During record is found, then further process continue, otherwise banned the page..

Posted 7-Jan-11 20:42pm

velmahesh

MohamadHajkhodabakhshi · Answer 5 · 2011-01-08T03:44:00

Solution 5

debug your code by break point and check string a and "or["aID"].ToString()" is equal or not, this method help you find your error

Posted 8-Jan-11 3:44am

MohamadHajkhodabakhshi

Updated 8-Jan-11 3:46am

v2