Connect 4 C# switching player turns problem

Question

0.00/5 (No votes)

See more:

Hello everyone for a school project I am making a connect 4 game were 2 players can play. I am stuck however on how to switch each player's turn. I have used a variable int PlayerNo that can either be 1 or 2 (player 1 or player 2) and changing this value determines whether a green counter (2) or a red counter (1) drop down the board. I need to know how to alternate this value every turn and below is all the code where the variable is used. My code is quite messy at the minute so please forgive me and if you need clarification on anything please ask me.

What I have tried:

C#

private void SwapPlayer(int playerNumber)
        {
            if (playerNumber == 1)
            {
                playerNumber = 2;
            }

            else if (playerNumber == 2)
            {
                playerNumber = 1;
            }
        }

Posted 2-Apr-16 14:54pm

Member 12144313

Updated 4-Apr-16 13:15pm

Patrice T

v3

Add a Solution

Comments

Per Söderlund 5-Apr-16 8:58am

It´s important that you understand the difference between value and reference type.
when you are passing an int (value type) as a parameter you are passing its value and you cannot change the variable you use when calling the SwapPlayer method.

If you change "private void SwapPlayer(int playerNumber)"
into "private void SwapPlayer(ref int playerNumber)"
you will pass in a reference to the variable and you can change it within the method.

Hope I didnt complicate things for you.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sascha Lefèvre · Accepted Answer · 2016-04-02T15:30:00

Solution 1

You declare playerNo as a local variable in slotArray_DragDrop(..). When the method is done, it's forgotten and the next time it's initialized with 1 again...

And you pass it as a value parameter into SwapPlayer(..) so any change being done to it doesn't reflect to playerNo in slotArray_DragDrop(..)...

Posted 2-Apr-16 15:30pm

Sascha Lefèvre

Comments

Member 12144313 4-Apr-16 18:24pm

That worked thank you