Crash when used iterator

Question

2.00/5 (1 vote)

See more:

Iam having issue with the following line of code its crashing in delete. could you please the code and let me know the issue

map::iterator it = m_Map.begin();

while ( it != m_Map.end() )
{
CTest*pDTerst(it->second);
if ( pDTerst)
delete pDTerst; /crashing some times
it++;
}
m_Map.clear();

What I have tried:

I tried debugged and found the issue in the

CTest*pDTerst(it->second);
if ( pDTerst)
delete pDTerst; /crashing some times

Posted 22-Mar-16 23:42pm

Member 11937050

Updated 23-Mar-16 0:06am

Add a Solution

Comments

Philippe Mori 23-Mar-16 21:33pm

Code above is not enough to really help you as that code might be correct or not depending on how the container is filled...

And you should use code blocks in you question to make code more readable. And also, code in "What I have tried" is the same code as above so this is redundant.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2016-03-23T00:06:00

You are creating a CTest instance on the stack and trying to delete it aftwerwards. That will of course crash because you can only delete objects that has been allocated on the heap using new.

So you would probably want to do something like this (depending on the type of the second std::pair element):

C++

delete it->second;

Note that there is no need to check for NULL because delete allows passing it (does nothing).