exception hanlding by try catch block

Question

0.00/5 (No votes)

See more:

I have read various article throwing and handling an exception is usually an expensive operation. i have reviewed code of many developer in my organisation and found that most of developer user this type code is given below

C#

private void RunnSqlLoader()
    {
        string sp1 = _strPath + _strFileName + ".bat";

        try
        {

            ProcessStartInfo startInfo = new ProcessStartInfo(@sp1)
            {
                WorkingDirectory = _strPath,
                CreateNoWindow = false,
                WindowStyle = ProcessWindowStyle.Hidden,
                UseShellExecute = false
            };
            Process batchExecute = new Process { StartInfo = startInfo };
            batchExecute.Start();
            batchExecute.WaitForExit();
        }
        catch (Exception ex)
        {
            throw ex;
        }


    }

so Is this code use better exception handling ?
or my point of view its not useful here. but i am not sure about?

please anybody explain me

Posted 8-Oct-15 0:06am

Anil Sharma1983

Updated 8-Oct-15 0:18am

CPallini

v2

Add a Solution

Comments

Philippe Mori 8-Oct-15 12:43pm

If you want to better understand proper exception handling, then this code is not a good starting point as it is pointless to catch an exception and fthrow it back without doing anything else...

3 solutions

Solution 2

It looks the original developer wanted to handle the exceptions but postponed the task (hence the re-throw). In any case the resulting code is just ugly.

Posted 8-Oct-15 0:21am

CPallini

Solution 3

This is just the basic syntax to handle the Exception and there are another ways to handle the exception but this is mostly used..

protected void Page_Load(object sender, EventArgs e)
{
if (!IsPostBack)
{
try
{
// Your code which is to be execute
}
catch (Exception ex)
{
// Log the exception

}
finally
{
// for dispose the Process/ Task

}
}
}

Posted 8-Oct-15 0:38am

Rakesh R Surve[RST]

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Accepted Answer · 2015-10-08T00:11:00

That code is exception handling, but pretty pointless handling. If all you are doing is re-throwing the exception then don't bother with the try\catch block. If you are going to rethrow then use just "throw" and not "throw ex" and you lose some exception context with you throw a new exception via "throw ex".