Sql query error in million dollar script

Question

1.00/5 (1 vote)

See more:

I have million dollar website script which enables me to sell pixel blocks but whenever i try to add new advertisement it gives me the following error.

"You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AS ID, t2.field_comment AS FCOMMENT FROM form_fields AS t1, form_field_translati' at line 1"

here is the complete query

SQL

"SELECT t2.field_label AS FLABEL, t1.* AS ID, t2.field_comment AS FCOMMENT FROM form_fields AS t1, form_field_translations AS t2 WHERE t1.field_id=t2.field_id AND lang='".$_SESSION['MDS_LANG']."' AND section='$section' AND form_id='$form_id' $where_sql order by field_sort"

please help.

What I have tried:

haven't tried anything yet i am still new to php and mysql therefore i am stuck in here thats why i downloaded a ready made script.

Posted 3-Aug-18 23:07pm

Member 13937634

Updated 4-Aug-18 0:00am

Richard MacCutchan

v2

Add a Solution

Comments

Mehdi Gholam 4-Aug-18 5:19am

Try spending some of the million dollars on training!

Richard MacCutchan 4-Aug-18 5:28am

t1.* AS ID
What do you think that asterisk is supposed to do?

And do not use code downloaded from the internet if you don't understand it. It will just give you more trouble than it is worth.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2018-08-03T23:29:00

How do you expect a possible multiple number of columns to be returned and given teh same name?

SQL

... , t1.* AS ID, ...

"*"returns multiple rows, and can;t be used with AS

Never use SELECT * ... FROM - always list your columns. That way, you have control over exactly what is returned, and the order it is returned in so database changes don't affect your code (unless a required column is removed, in which case you DEFINITELY want to know about it). It also helps with bandwidth, in that unnecessary columns aren't returned, which can waste a lot of bandwidth, memory, and time.

Patrice T · Accepted Answer · 2018-08-04T00:00:00

Because of the SQL injection problem, we have no idea of what is the real query.

PHP

"SELECT t2.field_label AS FLABEL, t1.* AS ID, t2.field_comment AS FCOMMENT FROM form_fields AS t1, form_field_translations AS t2 WHERE t1.field_id=t2.field_id AND lang='".$_SESSION['MDS_LANG']."' AND section='$section' AND form_id='$form_id' $where_sql order by field_sort"

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]

Sql query error in million dollar script

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0