Getting error executenonquery

Question

1.00/5 (1 vote)

See more:

It is supposed to subtract the Quantity of BagQty but I'm getting this ExecuteNonQuery error

What I have tried:

namespace BagQtyPractice
{
public partial class Form1 : Form
{
SqlConnection con = new SqlConnection("Server=DESKTOP- 1281SGB;Database=Practice;User Id=KicuCrafts; Password = admin; ");
SqlDataAdapter sda;
SqlCommandBuilder scb;
DataTable dt;
public Form1()
{

InitializeComponent();
}

private void btnAddtoCart_Click(object sender, EventArgs e)
{
SqlCommand cmd = con.CreateCommand();
cmd.CommandType = CommandType.Text;
cmd.CommandText = "update BagPracticeQty set BagQty=BagQty-" + txtQTY.Text;
cmd.ExecuteNonQuery();
}

Posted 1-Jul-18 3:13am

Member 13894029

Updated 1-Jul-18 4:04am

Add a Solution

Comments

sajeetharan 1-Jul-18 9:20am

Can you elloborate more on the error? what is the error

F-ES Sitecore 2-Jul-18 6:38am

Examine cmd.CommandText in the debugger to see exactly what SQL you are executing also look at the full exception message for more info. It can be handy to run the same code in SQL Server Management Studio.

Regardless your code has a few issues as it is, namely SQL Injection and also as there is no WHERE clause to limit the update to the item in question, your code is going to amend the quantity of every item in BagPracticeQty.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-07-01T04:04:00

Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

Once you have fixed that throughout you app - and miss one instance and you are at risk - you will probably find that your problem has disappeared.