Multi insert with same id

Question

0.00/5 (No votes)

See more:

Hi, i am trying to do multiple insert with same id. I did manage to create parametrised query which is working, but still looks kinda ugly by using the same parameter (@projekt) twice. Can somebody gimme a tip ? Thank you

What I have tried:

SQL

insert into Forma (formaNazwa, FK_projektId) 
values( 
			@forma1,
			(select projektId from Projekt where projektNazwa = @projekt)
		)
		,
		(
			@forma2,
			(select projektId from Projekt where projektNazwa = @projekt)
		)
;

C#

cmd1.Parameters.AddWithValue("@forma1",TextBoxProjectNameAdd.Text.ToString());
cmd1.Parameters.AddWithValue("@forma2",TextBoxProjectNameAdd1.Text.ToString());
cmd1.Parameters.AddWithValue("@projekt",TextBoxProjectNameAdd2.Text.ToString())

Posted 16-May-18 22:35pm

Member 13806021

Updated 17-May-18 1:00am

jaket-cp

v5

Add a Solution

Comments

F-ES Sitecore 17-May-18 4:54am

Google something like "sql insert with joins" as it would be better to join the tables normally and insert from the result of those joins rather than using the sub-queries you are using.

jaket-cp 17-May-18 5:21am

Or you could declare @projektId to store the projektId and used that as an insert for each record

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jörgen Andersson · Answer 1 · 2018-05-17T01:01:00

Solution 1

Nothing wrong with your solution.
But if you want it more "generic" you can try this:

SQL

insert into Forma (formaNazwa, FK_projektId) 
SELECT  formaNazwa.Value,projektId 
FROM    Projekt
CROSS JOIN (VALUES (@forma1),(@forma2)) AS formaNazwa(Value)
WHERE   projektNazwa = @projekt

Posted 17-May-18 1:01am

Jörgen Andersson

Updated 17-May-18 1:04am

v2