C# simple chess error

Question

1.00/5 (3 votes)

See more:

i have chess board,in the right side i have Combobox, textbox and buttons, from combobox i should choose type of piece for example` bishop,pawn and so on, in textbox i should write its coordinates for example`D5,and then click on button Create,but i have also Test button,which checks if all pieces exist on the board,for example if i have all pieces on the board besides pawn, when i click on button Test, it will give me MessageBox error.
How can i check it?
Thanks.

What I have tried:

I have tried like this but it's false.

private void Test_Click(object sender, EventArgs e)
        {
            if(comboBox1.SelectedItem != "Bishop" || comboBox1.SelectedItem != "Pawn")
            {
                MessageBox.Show("Error");
            }
        }

private void Form1_Paint(object sender, PaintEventArgs e)//This is my Chess board
        {
            for (int i = 0; i < 8; i++)
            {
                for (int j = 0; j < 8; j++)
                {
                    if((i+j) % 2 != 0)
                    gf.FillRectangle(Brushes.Black, (j + 1) * 50, (i+1)*50, 50, 50);
                }
                Label lb = new Label();
                lb.Text = Convert.ToChar('A' + i).ToString();
                lb.Font = new Font("Tahoma", 18);
                lb.Location = new Point(50 * (i + 1), 450);
                lb.Width = 50;
                lb.Height = 26;
                this.Controls.Add(lb);
            }
            for (int i = 8; i > 0; i--)
            {
                Label lab = new Label();
                lab.Text = i.ToString();
                lab.Font = new Font("Tahoma", 18);
                lab.Location = new Point(0, 50 *(9- i));
                lab.Width = 50;
                lab.Height = 26;
                this.Controls.Add(lab);
            }
        }


 private void create_Click_1(object sender, EventArgs e) //This is my Create button
        {
           
            if (comboBox1.SelectedItem == "Bishop")
            {
                string position = textBox1.Text;
                string first_letter = position[0].ToString().ToUpper();
                int x = (int)(first_letter[0] - 64);
                int y = int.Parse(position[1].ToString());
                gf.DrawImage(Properties.Resources.Bishop, x * 50, (8 - y + 1) * 50, 50, 50);
            }
            else if(comboBox1.SelectedItem == "Pawn")
            {
                string position = textBox1.Text;
                string first_letter = position[0].ToString().ToUpper();
                int x = (int)(first_letter[0] - 64);
                int y = int.Parse(position[1].ToString());
                gf.DrawImage(Properties.Resources.Pawn, x * 50, (8 - y + 1) * 50, 40, 50);
            }
        }

Posted 6-Mar-18 0:37am

Suren97

Updated 6-Mar-18 3:16am

v2

Add a Solution

Comments

Richard MacCutchan 6-Mar-18 6:46am

That logical operator should be &&, not ||. But what about all the other pieces?

Suren97 6-Mar-18 6:52am

i don't need all pieces, now i need only to check for that two pieces`pawn and bishop, i also tried operator && but it's not working too

Richard MacCutchan 6-Mar-18 8:42am

Then you are doing something wrong. But since you have not given any details we cannot guess what.

Suren97 6-Mar-18 8:45am

i can send you my Form1_Paint function

Richard MacCutchan 6-Mar-18 8:58am

If you have useful information about your problem, then please use the Improve question link above, and add it to your original query.

Suren97 6-Mar-18 9:15am

I updated, you can look.

Richard MacCutchan 6-Mar-18 9:22am

Why do you call ToString on strings?

Suren97 6-Mar-18 9:24am

what do you mean? because i need to call ToUpper()

Richard MacCutchan 6-Mar-18 9:33am

there is no need to call ToString on an item that is already a string. It makes no sense.

You are also duplicating code for no reason. Whether the selection is "Bishop" or "Pawn", the requirements are the same. So write a single method which can be called regardless of which piece you are referring to.

Suren97 6-Mar-18 9:34am

but i can't write position[0].ToUpper();

Richard MacCutchan 6-Mar-18 9:37am

Go to MSDN and read the documentation on the String and Char classes.

Suren97 6-Mar-18 9:44am

ok,i think now it's not important,will you help me what must i write in Test_click method?

Richard MacCutchan 6-Mar-18 10:03am

I am still not clear what you are trying to do with this. A chess program is normally created by drawing a board with images as pieces, allowing the user to drag and drop for each play.

Suren97 6-Mar-18 10:07am

ok,thanks :)

PeejayAdams 6-Mar-18 7:16am

Try looking at the SelectedValue property rather than SelectedItem. && is definitely the right operator.

Suren97 6-Mar-18 7:18am

ok i will try now

Suren97 6-Mar-18 7:20am

No,it give me error in all cases, now i have Bishop and pawn on the board, it mustn't give me error, but it give me error again

Suren97 6-Mar-18 7:23am

Look, i have Bishop and pawn in combobox, if i put both on the board then i click on button Test, it mustn't give me messageBox's error

Suren97 6-Mar-18 7:24am

But if i haven't put anyone of this it must give me messageBox's error

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-03-06T01:31:00

Richards change, is correct: think about what happens when you use "||" instead:

If the selected item is "Bishop" than it isn't "Pawn" - result == true.
If the selected item is "Pawn" than it isn't "Bishop" - result == true.
If the selected item neither "Bishop" nor "Pawn" - result == true.

With "&&" instead it works better:

If the selected item is "Bishop" - result == false.
If the selected item is "Pawn" - result == false.
If the selected item is neither "Bishop" nor "Pawn" - result == true.

But that won't help you with what you are trying to do, as the values remain in the combo box unless your code specifically removes them.

What you need to do is keep a "chess board" - a 8 x 8 array of pieces - in your memory. When he the user adds a piece, put it in the appropriate array location.
When he checks the "Test" button, scan through all the pieces on the board (by looking at the array) to find for what items are placed on it.