User and admin login page

Question

0.00/5 (No votes)

See more:

I dont know how to redirect users on control-panel.aspx page and admin on admin.aspx page.
I have tried this but not working.
Please help

What I have tried:

C#

<pre>  protected void Button1_Click(object sender, EventArgs e)
    {           
        string user = TextBox1.Text.Trim();
        cmd.CommandText = "select* from Users where Email='" + TextBox1.Text + "' and Password= '"+ TextBox2.Text +"'";
        cmd.Connection = con;
        sda.SelectCommand = cmd;
        sda.Fill(ds, "Users");
       
        SqlCommand check_User_Name = new SqlCommand("SELECT count([Role]) Users WHERE ([Role] = 'Admin' ");
        check_User_Name.CommandType = CommandType.Text;
        SqlDataAdapter sdaa = new SqlDataAdapter(check_User_Name);
        DataTable dt = new DataTable();      
        sdaa.Fill(dt);

            if (ds.Tables[0].Rows.Count > 0)
            {

                if (dt.Rows.Count > 0)
                {
                    Response.Redirect("Admin.aspx");
                }
                else
                {
                    Session["user"] = user;
                    Response.Redirect("Control-Panel.aspx");
                }
            }
            else
            {
                ScriptManager.RegisterStartupScript(this, this.GetType(), "Message", "alert('Something gone wrong');", true);
            }
    }

Posted 24-Jan-18 1:53am

Gatsby29

Updated 24-Jan-18 3:49am

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2018-01-24T02:12:00

For starters, don't do it like that! So many things wrong here...
1) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

And doing it on the login page for a website? Where anyone, anywhere can do what they want? That's almost criminally silly.

2) Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^] Combine that with teh SQL Injection, and I can log in as who I want, when I want, without even knowinhg a single password...

3) Get your SQL right.

C#

new SqlCommand("SELECT count([Role]) Users WHERE ([Role] = 'Admin' ");

Without a 'FROM' before 'Users' that will cause an SQL exception.

Fix these, in that order as a matter of priority throughout your whole app: or you will lose your database - heck you best mate will try it to see what happens and just to see the look on your face...

F-ES Sitecore · Accepted Answer · 2018-01-24T03:06:00

SELECT count([Role]) Users WHERE ([Role] = 'Admin'

This isn't valid, there is no "from" and you aren't closing the last parenthesis

SELECT count([Role]) from Users WHERE ([Role] = 'Admin')

Secondly if you think "Users" in this statement is accessing the "Users" table you created here;

sda.Fill(ds, "Users");

Then it isn't. Regardless if you have a field called "Role" in your users table then you don't need the second command, you already have the data you need in the "Users" table in "ds". Check the count of rows is 1 and if it is read the "Role" field of the first row of the data table and that will give you that user's role.

As OriginalGriff has already pointed out, literally everything you are doing here is bad :) I'll add to his comments by stating that your design means a person can only be in one role, but I appreciate you're just trying to get the basics working.

Karthik_Mahalingam · Accepted Answer · 2018-01-24T03:49:00

Try this

if (ds.Tables[0].Rows.Count > 0)
            {
                DataTable dtUsers = ds.Tables["Users"];
                Session["user"] = user;
                if (dtUsers.Rows.Count == 1) // it should return only one row 
                {
                    if (dtUsers.Rows[0]["Role"].ToString() == "Admin")
                    Response.Redirect("Admin.aspx");
                    else
                        Response.Redirect("Control-Panel.aspx");
                }
                else
                { 
                    Response.Redirect("Control-Panel.aspx");
                }
            }
            else
            {
                ScriptManager.RegisterStartupScript(this, this.GetType(), "Message", "alert('Something gone wrong');", true);
            }

Since you have already filled the user information into the dataset, there is no need to query the role once again to check the role, you shall get the role information from the dataset it self.

Note: Concatenating the sql Query string is vulnerable to SQL Injection[^] attacks,always use Parameterized queries to prevent SQL Injection Attacks in SQL Server[[^]

you shall remove these codes

SqlCommand check_User_Name = new SqlCommand("SELECT count([Role]) Users WHERE ([Role] = 'Admin' ");
      check_User_Name.CommandType = CommandType.Text;
      SqlDataAdapter sdaa = new SqlDataAdapter(check_User_Name);
      DataTable dt = new DataTable();
      sdaa.Fill(dt);

User and admin login page

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0