Fix my SQL server 2008

Question

1.00/5 (2 votes)

See more:

Error converting data type nvarchar to numeric.

What I have tried:

SQL

select MAX(cast(number_qamema as decimal(15,4))) as NB_QE from DB_DAEN where name_costomer1='waleed'  group by name_costomer1

Posted 22-Jan-18 11:26am

waleed_akre

Updated 22-Jan-18 13:44pm

PIEBALDconsult

v2

Add a Solution

Comments

PIEBALDconsult 22-Jan-18 17:58pm

We'd need to see some sample data.

CHill60 23-Jan-18 4:25am

Hint: Don't store numbers (or dates) as varchar columns. Use the correct column type.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

an0ther1 · Accepted Answer · 2018-01-22T13:44:00

Solution 1

The error is caused by your data - the column number_qanema cannot be converted to a decimal value.
Change your query as follows;

SQL

SELECT
    MAX(CAST(number_qamema AS DECIMAL(15,4))) AS NB_QE 
FROM
    NB_QE
WHERE
    ISNUMERIC(number_qamema) = 1
    AND
    name_costomer1 = 'waleed'
GROUP BY
    name_costomer1

Kind Regards

Posted 22-Jan-18 13:44pm

an0ther1

Comments

Richard Deeming 23-Jan-18 12:05pm

Be careful with ISNUMERIC - it considers some strings as numeric which can't be cast to a number.

Also, depending on the data, you might still end up with errors. In some cases, SQL might choose to evaluate the CAST before the WHERE clause.

For SQL 2012 or higher, TRY_PARSE[^] would be a better option:

SELECT
    name_costomer1,
    MAX(TRY_PARSE(number_qamema As decimal(15, 4))) As NB_QE
FROM
    NB_QE
GROUP BY
    name_costomer1
;

an0ther1 23-Jan-18 16:04pm

Thanks for the info Richard, much appreciated.