How to use column names from list into mysql insert

Question

1.00/5 (1 vote)

See more:

I have 2 lists and want to use them in mysql insert parameter:

What I have tried:

C#

List<string> ColumnNames = new List<string>();
List<string> ValueNames = new List<string>();
ColumnNames = names.Keys.ToList();
ValueNames = names.Values.ToList();

I'm trying to use this lists into MySql statement:

C#

...
MySqlCommand command = conDataBase.CreateCommand();
command.CommandText = string.Format("insert into MyTable {0} values (?parameter)", string.Join(",", ColumnNames));
command.Parameters.AddWithValue("parameter", string.Join(",", ValueNames));
...

but I'm taking syntax error, then I have tryed many experiments, like:

C#

...
command.CommandText = "insert into MyTable (" + string.Join(",", ColumnNames) + ") values ('" + string.Join(",", ValueNames) + "')";
...

and

C#

...
command.CommandText = "insert into MyTable (" + string.Join(",", ColumnNames) + ") values (?parameter)";
command.Parameters.AddWithValue("parameter", string.Join(",", ValueNames));
...

I'm taking error "Column count doesn't match value count at row 1", but

C#

ColumnNames.Count = ValueNames.Count

Posted 15-Jan-18 1:53am

Member 12361495

Updated 16-Jan-18 6:19am

CHill60

v2

Add a Solution

Comments

CHill60 15-Jan-18 8:00am

What is the content of command.CommandText after you have done that string format and what is the content of string.Join(",", ValueNames)

Member 12361495 15-Jan-18 8:19am

command.CommandText = insert into msoflioqveknebisklasifikatori (cifruliKodi,dasaxeleba,sruliDasaxeleba,KodiAlfa2,KodiAlfa3) values (', , , , ')
ValueNames content is array of strings

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Altaf Ansari · Accepted Answer · 2018-01-15T02:40:00

Solution 1

Try This :

 List<string> ColumnNames = names.Keys.ToList()
      List<string> ValueNames = names.Values.ToList();
      List<string> RevValueNames = new List<string>();
      ValueNames.ForEach(x => RevValueNames.Add("'" + x + "'"));
string Query = string.Format("insert into MyTable ({0}) values ({1})", string.Join(",", ColumnNames), string.Join(",", RevValueNames));
            command.CommandText = Query;

Posted 15-Jan-18 2:40am

Altaf Ansari

Updated 15-Jan-18 2:42am

v2

Comments

Member 12361495 15-Jan-18 8:46am

yes!!!, thank you very much
there is a little mistake instead of {0} must be ({0}).
Thank you

Altaf Ansari 15-Jan-18 8:54am

Yes i have revised the answer..

Richard Deeming 16-Jan-18 12:14pm

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

Richard Deeming · Accepted Answer · 2018-01-16T06:19:00

NB: Make sure your column names cannot be provided by the user, otherwise you will leave yourself open to SQL Injection[^].

Something like this should work:

C#

command.CommandText = string.Format("INSERT INTO MyTable ({0}) VALUES (?{1})", 
    string.Join(",", names.Keys), 
    string.Join(",?", names.Keys));

// Eg: "INSERT INTO MyTable (col1, col2) VALUES (?col1, ?col2)"

foreach (KeyValuePair<string, string> pair in names)
{
    command.Parameters.AddWithValue(pair.Key, pair.Value);
}

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]