C# setting up all buttons in different forms

Question

1.00/5 (1 vote)

See more:

im trying to use my public method to every form. what i want is when the method is call, find all the buttons in a form and play system sound in each button when it is CLICKED.

What I have tried:

public static void setButtons(Form  f)
{
    foreach (Control c in f.Controls)
    {
        Button btn = c as Button;

        if (c == btn)
        {
            System.Media.SystemSounds.Beep.Play();
        }
    }
}

Posted 2-Dec-17 22:57pm

akosisugar

Updated 3-Dec-17 0:31am

Add a Solution

2 solutions

Solution 1

You need to use the control's InvokeRequired property, see:
How to: Make Thread-Safe Calls to Windows Forms Controls | Microsoft Docs[^]

Posted 2-Dec-17 23:13pm

RickZeeland

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

________________ · Accepted Answer · 2017-12-03T00:31:00

Solution 2

public static void setButtons(Form  f)
        {
            foreach (Control c in f.Controls)
            {
                Button btn = c as Button;
 
                if (c == btn)
                {
					btn.Click += btn_Click;
                }
            }
        }

		static void btn_Click(object sender, EventArgs e)
		{
			System.Media.SystemSounds.Beep.Play();
		}

Posted 3-Dec-17 0:31am

________________

Comments

akosisugar 3-Dec-17 6:51am

im calling the method in form_load event.. your code doesnt work

________________ 3-Dec-17 8:39am

I call setButtons(Form f) from constructor of form:

public partial class Form2 : Form
{

public Form2(object dataToShow)
{
InitializeComponent();
//dataGridView1.DataSource = dataToShow;
setButtons(this);
}

public static void setButtons(Form f)
{
foreach (Control c in f.Controls)
{
Button btn = c as Button;

if (c == btn)
{
btn.Click += btn_Click;
}
}
}

static void btn_Click(object sender, EventArgs e)
{
System.Media.SystemSounds.Beep.Play();
}

}

Do you understand what is event in .NET?

________________ 3-Dec-17 8:48am

You can call the "setButtons(Form f)" from any place, but you should send as parameter correct form. This is the point. In my example, I send "this" from form constructor, so it sure will be correct object.

akosisugar 3-Dec-17 10:20am

yess i do understand event..

sorry sorry.. its working now..

________________ 4-Dec-17 2:09am

All ok. In C++ it was pointer to function, simple 32 bit integer (address in memory), in In .NET it almost the same, but better protected(by name and parameters).
So, event in class is collection (may be null if empty) of "pointers to function".

akosisugar 4-Dec-17 8:06am

thank you again sir!