Get data() compilation error

Question

1.00/5 (2 votes)

See more:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Data;
using System.Text;

public partial class Default2 : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        if (!IsPostBack)
        {
            DropDownList1.DataSource = GetData();
            DropDownList1.DataValueField = "Branch";
            DropDownList1.DataTextField = "Branch";
            DropDownList1.DataBind();
        }
    }
    protected void DropDownList1_SelectedIndexChanged(object sender, EventArgs e)
    {
        using (SqlConnection Cn = new SqlConnection(@"Data Source=(LocalDB)\v11.0;AttachDbFilename=F:\AAAAAAAAAAA\FINGERPRINT\APP_DATA\QUESTIONS.MDF;Integrated Security=True;")) 
        {
            using (SqlCommand Cmd = new SqlCommand("select * from questions where Branch= @Branch"))
            {
                Cn.Open();

                Cmd.Parameters.AddWithValue("@Branch", int.Parse(DropDownList1.SelectedValue));
                SqlDataReader Dr = Cmd.ExecuteReader();
                if (Dr.HasRows)
                {
                    GridView1.DataSource = Dr;
                    GridView1.DataBind();
                }
                Dr.Close();

                Cn.Close();
            }

        }
    }
   DataTable GetData()
    {
        DataTable dt = new DataTable();
         SqlConnection Con = new SqlConnection(@"Data Source=(LocalDB)\v11.0;AttachDbFilename=F:\AAAAAAAAAAA\FINGERPRINT\APP_DATA\QUESTIONS.MDF;Integrated Security=True;");
        {
             SqlCommand Cmd = new SqlCommand("SELECT * FROM  questions ");
            
                Con.Open();
                SqlDataAdapter adpt = new SqlDataAdapter(Cmd);
                adpt.Fill(dt);
            }

        }
    }

What I have tried:

i have try add protected but get same error in data table getdata()

Posted 8-Apr-17 23:25pm

Member 13045876

Updated 9-Apr-17 0:11am

Add a Solution

Comments

Tomas Takac 9-Apr-17 5:58am

What error?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tomas Takac · Answer 1 · 2017-04-09T00:06:00

In GetData() method you are creating the data table but never returning it so I assume your compilation error is "not all paths are returning a value". It should look like this:

C#

DataTable GetData()
{
    DataTable dt = new DataTable();
    using(SqlConnection Con = new SqlConnection(@"Data Source=(LocalDB)\v11.0;AttachDbFilename=F:\AAAAAAAAAAA\FINGERPRINT\APP_DATA\QUESTIONS.MDF;Integrated Security=True;"))
    using(SqlCommand Cmd = new SqlCommand("SELECT * FROM  questions ", Con))
    {		
    	Con.Open();
    	SqlDataAdapter adpt = new SqlDataAdapter(Cmd);
    	adpt.Fill(dt);
    }
    return dt; // <-- this is what you were missing
}

Please note I added using statements as both SqlConnectin and SqlCommand implement IDisposable.

OriginalGriff · Answer 2 · 2017-04-09T00:10:00

Solution 2

You declared GetData as returning a DataTable, but the method does not return anything.
Add this line at the end of the method:

C#

return dt;

BTW: don't hardcode connection strings: read them from a configuration file!

Posted 9-Apr-17 0:10am

OriginalGriff