I am writing code to add digits exampe 153=(1+5+3)=9

Question

1.00/5 (1 vote)

See more:

i think this code is mathamatically correct ....but when i run this code ...the programm give some awkward and same number all the time ...i am getting confused ,i have tried this code a number of times now..plz tell me what is wrong ..
ps: iam beginner

What I have tried:

#include <iostream>

using namespace std;

int main()
{
int num,sum,a=0;
cin>>num;
while(num>0)
{
a=num%10;

sum=sum+a;
num=num/10;

}
cout<<sum<<endl;
return 0;
}

Posted 5-Jan-17 0:02am

Member 12914219

Updated 5-Jan-17 1:47am

Add a Solution

Comments

Philippe Mori 5-Jan-17 9:01am

Something like that would works : sum = num > 0 ? (num + 8) % 9 + 1 : 0;

2 solutions

Solution 3

Quote:
i think this code is mathematically correct

If the result is wrong, the program is wrong, somewhere. The debugger will show you what your program is really doing.

You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

Posted 5-Jan-17 1:47am

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2017-01-05T00:15:00

This line declares the variables num, sum, and a and initialises a with zero but the value of num and sum is undefined.

int num,sum,a=0;

While num and a are assigned later by code, there is no value assigned to sum but the actual value is used.

So you should change your code to (splitted into multiple lines here):

int num = 0;
int sum = 0;
int a = 0;