Cannot access a closed Stream

Question

2.33/5 (3 votes)

See more:

Hi Friends
I Made a XmlTextWriter in MemoryStream

Then I Want Make a XmlDocument Using MemoryStream.
But I Have Following a Error Message: "Cannot access a closed Stream"

XmlTextWriter xmlwr = new XmlTextWriter(MemoryStream,System.Text.Encoding.UTF8);
//Other Codes..
xmlwr.Close();
XmlDocument x = new XmlDocument();
x.Load(MemoryStream);

Posted 20-Apr-11 22:59pm

zsh64

Updated 21-Apr-11 1:32am

musefan

v4

Add a Solution

Comments

FatimaAsif 25-Jul-12 6:46am

i also have this error , i never close stream before but it gives this error ? why?

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

musefan · Answer 1 · 2011-04-20T23:05:00

Solution 3

I think that closing the XmlTextWriter will also close the MemoryStream that it is using.

Also, where is your MemoryStream declared? is it closed before you use it it XmlTextWriter?

maybe something like this will work better...

using(MemoryStream ms = new MemoryStream())
{
   using(XmlTextWriter xmlwr = new XmlTextWriter(ms,System.Text.Encoding.UTF8))
   {
      //Other codes...
      ms.Position = 0;//need to set the stream back to the start so it can be read
      XmlDocument x = new XmlDocument();
      x.Load(ms);
   }
}

Posted 20-Apr-11 23:05pm

musefan

Updated 21-Apr-11 1:28am

v2

Comments

Sergey Alexandrovich Kryukov 21-Apr-11 5:11am

Not sure... please check up this: "other codes" probably write the stream and leave the stream position at the end. You need to rewind the memory stream back to zero position before you can load.
Right?

Also, see my answer which is an alternative to yours. Why stream?
--SA

zsh64 21-Apr-11 5:41am

Several times this file is made for the same should be stored in MemoryStream

Sergey Alexandrovich Kryukov 21-Apr-11 16:11pm

Who say it "should be"? Why? If the same file is created N times, N-1 timer are not needed :-)
--SA

musefan 21-Apr-11 7:27am

Yes, you are right! I had forgot about that. Thanks I will amend my solution

musefan 21-Apr-11 7:34am

Oh, and I used stream because OP using stream. Also, perhaps the 'other codes' creates the XML from a string (which you do need XMLTextWriter for)

Sergey Alexandrovich Kryukov 21-Apr-11 16:21pm

Yes, it would immediately work as a quick fix. After you fixed the stream position (it looks like it should work now) -- my 5.
--SA

Ankit Rajput · Answer 2 · 2011-04-20T23:01:00

Solution 1

First try to load the document from MemoryStream then close XmlTextWriter

Do it like this:

XmlDocument X=new XmlDocument()
x.Load(MemoryStream) 
XmlTextWriter .Close()

Posted 20-Apr-11 23:01pm

Ankit Rajput

Updated 20-Apr-11 23:02pm

v2

Comments

zsh64 21-Apr-11 5:35am

If i do it Gives the following message
"Root element is missing"

Ankit Rajput 21-Apr-11 7:34am

In that case, Check your XML data which you have created.

Sergey Alexandrovich Kryukov · Answer 3 · 2011-04-20T23:03:00

Wow! You close the stream with your own hands and wonder why it is closed!
You close it through closing of the xmlwr.

You need different approach. All problem is your "Other codes".
Instead of writing something into some really unwanted stream, write directly to XmlDocument; create it empty and populate. This class represent DOM; and every node is editable; you just add nodes and properties. You have everything if your "Other codes" part is able to write XML.

—SA

Cannot access a closed Stream

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us