RE: error in program , infinite loop

Question

1.00/5 (1 vote)

See more:

the following program executes without bug but give an infinite loop on entering text..

What I have tried:

C++

#include<iostream.h>
#include<conio.h>
#include<string.h>
#include<stdio.h>
int change(char[]);

void main()
{
	int i,y,j=0,w;
	char str[100],word[1000];
	clrscr();
	cout<<" enter text"<<endl;
	gets(word);
	cout<<"The string before block"<<endl;
	puts(word);
	cout<<"The string after block"<<endl;
	for(i=0;word[i]!='\0';++i)
	{
		if(word[i]!=' ')
		{
			str[j] = word[i];
			j++;
		}
		if(word[i]==' ')
		{
			w=change(str);
			if(w==1)
			{
				for(i=1;i<j-1;++i)>
				{
					str[i]='*';
				}
				cout<<str<<" ";
				j=0;
			}
			if(w==0)
			{
				cout<<str<<" ";
				j=0;
			}
		}
	}
	getch();
}

int change(char  str[])
{

	if((strcmp(str,"poop")==0)||(strcmp(str,"bad")==0))
	return 1;
	else return 0;
}

Posted 22-Jun-16 0:50am

Member 12537459

Updated 22-Jun-16 10:40am

Patrice T

v3

Add a Solution

Comments

phil.o 22-Jun-16 7:13am

Correct identation of your code would make your life, and ours, so much easier :)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-06-22T01:13:00

Indentation really, really helps when you code: it makes it a lot simpler to spot what is going on:

C++

for (i = 0; word[i] != '\0'; ++i)
    {
    if (word[i] != ' ')
        {
        str[j] = word[i];
        j++;
        }
    if (word[i] == ' ')
        {
        w=change(str);
        if (w == 1)
            {
            for (i = 1; i < j - 1; ++i)
                {
                str[i] = '*';
                }
            cout<<str<<" ";
            j = 0;
            }
        if (w == 0)
            {
            cout<<str<<" ";
            j = 0;
            }
        }
    }

In this case, it would make it obvious that you are using the same variable for two nested loops...which means that after the second loop, the value of i will always be the same.
And if you'd used the debugger, that would also have made it pretty obvious!