how to fix this code ?

Question

0.00/5 (No votes)

See more:

C#

SqlStr = " Delete from FilelibF where IdAttachBord = + GridFile.SelectedRows[0].Cells[0].Value + ";
sqlcmd = new SqlCommand(SqlStr, cn);
sqlcmd.ExecuteNonQuery();

when i want to delete some file in my program it says : Incorrect syntax near '0'. what is that mean and how to fix it ?!!

Posted 26-Dec-15 2:45am

brandon1999

Updated 26-Dec-15 2:47am

v4

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2015-12-26T02:56:00

Solution 1

The GridFile.SelectedRows[0].Cells[0].Value part is inside the quotes, so it gets treated as a part of the query. You have to close the quotes before the + operator.

However, string concatenation for SQL queries is a bad idea: you're vulnerable for SQL injection[^]. Use parameterized queries instead: they fix the vulnerability and make your query more readable.

C#

SqlStr = "Delete from FilelibF where IdAttachBord = @SelectedCell";
sqlcmd = new SqlCommand(SqlStr, cn);
sqlcmd.Parameters.Add(new SqlParameter("SelectedCell", GridFile.SelectedRows[0].Cells[0].Value));
sqlcmd.ExecuteNonQuery();

Posted 26-Dec-15 2:56am

Thomas Daniels

Comments

brandon1999 26-Dec-15 9:00am

ok, thank u so much.

Thomas Daniels 26-Dec-15 9:01am

You're welcome!

brandon1999 26-Dec-15 9:02am

can u fix this too please

http://www.codeproject.com/Questions/1067194/how-to-fix-this-error

Thomas Daniels 26-Dec-15 9:11am

I've looked at it but I'm not sure... I would know how to convert a string to a byte array, but perhaps that isn't the best solution: you appear to need a byte array, so why store it as a string in the database? However, I don't work with databases very much, so I wouldn't be able to give a detailed explanation on that. And perhaps there is even another, better, solution that I'm not aware of.

brandon1999 26-Dec-15 9:35am

thanks i've been fixed it.

Sergey Alexandrovich Kryukov 26-Dec-15 11:00am

5ed.
—SA

Thomas Daniels 26-Dec-15 11:03am

Thank you.