parameterized store procedure and winforms comboboxes

Question

0.00/5 (No votes)

See more:

SQL-Server-2014

In my tblSates Table, I have a column named Monat with these three values [01.2016, 02.2016 and 03.2016] and I want to fetch these values in a combobox.

I am getting the values but just two of them instead of all three. And I debug I stil get two values.
[02.2016 and 03.2016]
Here my code:

C#

private void FillCombobox2()
    {
        string S = ConfigurationManager

        // TSQL-Statement
        SqlCommand cmd = new SqlCommand();
        cmd.Connection = con;
        cmd.CommandText = ("SELECT DISTINCT Monat from tblSales");            
        SqlDataReader myReader;
        try
        {
            con.Open();
            myReader = cmd.ExecuteReader();
            if (myReader.Read())
            {
                DataTable dt = new DataTable();
                dt.Load(myReader);
                combobox1.DisplayMember = "Monat";
                combobox1.ValueMember = "Monat";
                combobox1.DataSource = dt;
                combobox1.SelectedIndex = -1;

            }

        }
        catch (Exception ex)
        {
            MessageBox.Show(ex.Message);
        }
        finally
        {
            con.Close();
        }
    }

Posted 21-May-15 0:05am

mikybrain1

Updated 21-May-15 1:52am

v2

Add a Solution

Comments

Sinisa Hajnal 21-May-15 6:41am

Your Periode1.SelectedValue is most probably null / nothing / not set.
Either check for it and put dbnull.value into the parameter or give it some default value and check in SP for it

kashif Atiq 21-May-15 8:08am

what is the data type of column Monat?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

mikybrain1 · Accepted Answer · 2015-05-21T02:07:00

C#

private void FillCombobox2()
    {
        string S = ConfigurationManager
 
        // TSQL-Statement
        SqlCommand cmd = new SqlCommand();
        cmd.Connection = con;
        cmd.CommandText = ("SELECT DISTINCT Monat from tblSales");            
        //SqlDataReader myReader;
        try
        {
            con.Open();
         SqlDataAdapter ad = new SqlDataAdapter(cmd);
         DataTable dt = new DataTable();
                ad.Fill(dt)             
                combobox1.DisplayMember = "Monat";
                combobox1.ValueMember = "Monat";
                combobox1.DataSource = dt;
                combobox1.SelectedIndex = -1;
 
            }
 
        }
        catch (Exception ex)
        {
            MessageBox.Show(ex.Message);
        }
        finally
        {
            con.Close();
        }
    }