How do I make the scanf to work ?

Question

1.00/5 (1 vote)

See more:

//This is just a part of a big code. In this function I want ot print all the results in the linked list having the same zipcode as the one entered by the user. But the scanf to input the zipcode from the user doesn't seem to work. When i print the zipcode it says NULL//

C++

void searchzip()
{
char code[6];
printf("\nPlease enter the zip code that you want to search :\n");
scanf("%s",code[6]);
printf("\n%s",code[6]);
struct student *temp=head;
do
{
if(strcmp(code,temp->zip)==0)
	{
	printf("\nFirst name: %s Last name: %s Score: %f ZipCode: %s",temp->firstname,temp->lastname,temp->score,temp->zip);
	}
temp=temp->next;
}
while(temp!=NULL);
}

Posted 11-May-15 10:05am

User 11534381

Updated 11-May-15 11:21am

CPallini

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2015-05-11T10:25:00

Solution 1

First of all,

C++

scanf("%s",code);

But then, it's not clear why scanning it as string ("%s"), why not using gets_s. If you want zip code, it could be

C++

int zipCode;
scanf("%d", &zipCode);

For further progress, 1) use the debugger, 2) read the documentation: http://www.cplusplus.com/reference/cstdio/scanf[^].

—SA

Posted 11-May-15 10:25am

Sergey Alexandrovich Kryukov

Updated 12-May-15 2:27am

v3

Comments

[no name] 11-May-15 17:07pm

The program askes us to have the zipcode as an string.

Sergey Alexandrovich Kryukov 11-May-15 17:26pm

This is wrong, but for string use just gets_s. Anyway, I answered... :-)
—SA

CPallini 11-May-15 17:23pm

5.

Sergey Alexandrovich Kryukov 11-May-15 17:26pm

Thank you, Carlo.
—SA

Sascha Lefèvre 11-May-15 17:31pm

+5

Sergey Alexandrovich Kryukov 11-May-15 17:35pm

Thank you, Sascha.
—SA

[no name] 11-May-15 18:55pm

Thanks !

Sergey Alexandrovich Kryukov 11-May-15 19:16pm

You are welcome.
—SA

Frankie-C 12-May-15 5:38am

In some countries (i.e. UK) the ZIP codes are Alphanumeric.
The most recent revision of the C standard (2011) has definitively removed the function gets() from its specification.
The function is deprecated in C++ (as of 2011 standard, which follows C99+TC3).
Actuallly is available the safe extension gets_s(), under the technical report ISO TR24731-1, in C99, C11 and C++11.

Sergey Alexandrovich Kryukov 12-May-15 8:26am

All right, thank you for the notes and correcting me.
—SA

Frankie-C 12-May-15 8:38am

Thanks Sergey.
You gave the correct answer, but let me add, for sake of precision and especially for the novices that don't know, that in C the name of an array is the address where it begins (or the address of the first element). So in C where is required an array simply pass the name of the array.
Moreover C don't checks bounds, it's up to you to avoid memory corruption.

Sergey Alexandrovich Kryukov 12-May-15 9:09am

This is a good point to mention, too.

However, it might not be the place to teach all aspects we can reach from this code. My initial plan was to point out only one mistake, to let the inquirer to face all the rest later. This is a fair strategy. You don't have to eat the whole egg to tell it's bad.

Thank you very much.
—SA