Problem displaying ArrayList items in a listbox.

Question

1.00/5 (1 vote)

See more:

C#

private void frmBookstore_Load(object sender, EventArgs e)
        {
            setUpBookStore();
        }

        private void btnBkStock_Click(object sender, EventArgs e)
        {
            showListOfBooks();

private void setUpBookStore()
        {
            bookstore.Add(new Book1("Spills","Kendrick Williermson", "2015", "5", "4532145321"));

            bookstore.Add(new Book1("Ken", "Lierm Pattasun", "1903", "20", "1235412354"));

            bookstore.Add(new Book1("A Secret Chamber", "Harry Potter", "0000", "10000000", "1111111111"));

            bookstore.Add(new Book1("Eddie", "Rik Mayall", "2000", "31", "7483758376"));

            bookstore.Add(new Book1("Stella the Tortoise", "BL. Ager", "1519", "223", "0003200067"));
        }

        private void showListOfBooks()
        {
            //clear listbox first
            lstBooks.Items.Clear();

            //output data 
           foreach (Book1 b in bookstore)
                lstBooks.Items.Add(b.getTitle() + "by" + b.getAuthor() + 
                    ". Isbn: " + b.getIsbn() + "Year: " + b.getYear() + ".");
        }

I can't understand what else i need to do to gt it to display in the listbox when i click the "BkStock" button. The book class has been created with 5 variables. What am I missing?

Posted 22-Feb-15 10:29am

Bawwla

Add a Solution

Comments

Sergey Alexandrovich Kryukov 22-Feb-15 17:01pm

Start with not using ArrayList. This type is obsolete. Use System.Collections.Generic.List<>.
"Display" — what would you mean by that? Display where?...
—SA

Bawwla 22-Feb-15 17:27pm

So in the form when I click the button, hence "btnBkStock_Click", it shows the list of books that were added to the arraylist in the "showListOfBooks" method called when the form is loaded. If it makes it clearer the form contains simply a button to show the books, and a listbox to print them

Kuthuparakkal 22-Feb-15 17:15pm

Unclear

Andreas Gieriet 22-Feb-15 17:28pm

What is the symptom? Did you try debugging?
Andi

Bawwla 22-Feb-15 17:29pm

Form loads up, but simply nothing happens when I click the button.

Andreas Gieriet 22-Feb-15 17:33pm

Go and debug. Set a breakpoint in the method you assume gets called. Check that the list gets filled as expected. Go on from there...
Andi

Bawwla 22-Feb-15 17:58pm

The lists gets filled as I would expect, but the foreach loop only loops once (so only to show 1 book, not all 5 as I want) and it still doesn't get shown in the list box

Andreas Gieriet 22-Feb-15 18:16pm

If the loop is not executed as many times as you expect, go and fix that first.
Also check out the ListBox class description in MSDN. The example in the Items property shows how to deal with re-drawing, etc.
Andi

Kuthuparakkal 22-Feb-15 19:57pm

May be you are missing a linefeed between data.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kuthuparakkal · Answer 1 · 2015-02-22T14:00:00

Try this:

C#

using System;
using System.Collections;
using System.Windows.Forms;

namespace BookstoreTest
{
    public partial class Form1 : Form
    {
        ArrayList bookstore;
        public Form1()
        {
            InitializeComponent();
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            bookstore = new ArrayList();
            setUpBookStore();
        }

        private void btnBkStock_Click(object sender, EventArgs e)
        {
            showListOfBooks();
        }

        private void setUpBookStore()
        {
            bookstore.Add(new Book1("Spills", "Kendrick Williermson", "2015", "5", "4532145321"));

            bookstore.Add(new Book1("Ken", "Lierm Pattasun", "1903", "20", "1235412354"));

            bookstore.Add(new Book1("A Secret Chamber", "Harry Potter", "0000", "10000000", "1111111111"));

            bookstore.Add(new Book1("Eddie", "Rik Mayall", "2000", "31", "7483758376"));

            bookstore.Add(new Book1("Stella the Tortoise", "BL. Ager", "1519", "223", "0003200067"));
        }

        private void showListOfBooks()
        {
            //clear listbox first
            lstBooks.Items.Clear();

            //output data
            foreach (Book1 b in bookstore)
            {
                lstBooks.Items.Add(b.Title + "by" + b.Author + ". Isbn: " + b.ISBN + "Year: " + b.Year + "." + Environment.NewLine);
            }
        }
    }

    public class Book1
    {
        public string Title
        {
            get;
            set;
        }

        public string Author
        {
            get;
            set;
        }

        public string Year
        {
            get;
            set;
        }
        public string Month
        {
            get;
            set;
        }

        public string ISBN
        {
            get;
            set;
        }

        public Book1(string _Title, string _Author, string _Year, string _Month, string _ISBN)
        {
            this.Title = _Title;
            this.Author = _Author;
            this.Year = _Year;
            this.Month = _Month;
            this.ISBN = _ISBN;

        }
    }
}