Issue in Insert DateTime in DB

Question

1.00/5 (1 vote)

See more:

SQL-Server-2008R2

I want to insert DateTime from C# to SQL server DB. I create example query before test in C#. but error occur.

Please anyone help................... What is error in following query???????

SQL

DECLARE @ActivityDate as date
DECLARE @SqlQuery as varchar(1000)

SET @ActivityDate=current_timestamp
SET @SqlQuery='Insert into TestDB (ActivityDate) VALUES ('+CAST(@ActivityDate as datetime)+')'
Exec(@SqlQuery)

Error:
Error during conversion from character string to datetime

Thanks in advance

Posted 30-Dec-14 6:12am

DoingWork

Add a Solution

Comments

Kornfeld Eliyahu Peter 30-Dec-14 12:29pm

You know what the error is! Please share with us so we can examine it!

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

BechirBenltaief · Accepted Answer · 2014-12-31T02:02:00

Hi,

this is another solution,
Using sp_executesql is better then using exec, because store the execution plan and avoid syntax error to have clean and elegant code

SQL

DECLARE @ActivityDate as date;
DECLARE @SqlQuery as nvarchar(1000)
DECLARE @ParmDefinition nvarchar(500);

SET @ActivityDate=current_timestamp;
SET @ParmDefinition = N'@ActivityDate datetime';
SET @SqlQuery='Insert into TestDB (ActivityDate) VALUES (@ActivityDate)'

execute sp_executesql @SqlQuery, @ParmDefinition, @ActivityDate = @ActivityDate

hope that help,
Bechir.

Suvendu Shekhar Giri · Accepted Answer · 2014-12-30T06:46:00

You can't concatenate datetime value with a string.

Problem is in the line

SQL

SET @SqlQuery='Insert into TestDB (ActivityDate) VALUES ('+CAST(@ActivityDate as datetime)+')'

Check following -

SQL

DECLARE @ActivityDate as date
DECLARE @SqlQuery as varchar(1000)
 
SET @ActivityDate=current_timestamp
SET @SqlQuery='Insert into TestDB (ActivityDate) VALUES ('''+CAST(CAST(@ActivityDate as datetime) AS VARCHAR)+''')'
Exec(@SqlQuery)

Note that I have also added 2 single quotations before and after the value after casting it to varchar value.

I hope this was helpful :)

Update 1:
To get complete date with time you need to change the datatype of @ActivityDate to DATETIME as follows

SQL

DECLARE @ActivityDate as DATETIME
DECLARE @SqlQuery as varchar(1000)
 
SET @ActivityDate=current_timestamp
SET @SqlQuery='Insert into TestDB (ActivityDate) VALUES ('''+CAST(@ActivityDate AS VARCHAR)+''')'
Exec(@SqlQuery)

Update 2:
To get value till minute, second & milliseconds you need to use CONVERT instead of CAST. Note that code 113 or 13 will give us the desired result.

SQL

DECLARE @ActivityDate as DATETIME
DECLARE @SqlQuery as varchar(1000)
 
SET @ActivityDate=current_timestamp
SET @SqlQuery='Insert into TestDB (ActivityDate) VALUES ('''+CONVERT(VARCHAR,@ActivityDate,113)+''''
Exec(@SqlQuery)

Issue in Insert DateTime in DB

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0