drodown list selected item unable to insert into sql inserting only first item as default, can any one help plz

Question

0.00/5 (No votes)

See more:

C#

protected void Page_Load(object sender, EventArgs e)
   {
      
       Bindtype();
       

   }

--------------------

private void Bindtype()
{
try
{
string qry = "select MC_Type from dtdc_mctype";
SqlDataAdapter da = new SqlDataAdapter(qry, con);
DataTable dt = new DataTable();

da.Fill(dt);
droptype.DataSource = dt;

droptype.DataValueField = "MC_Type";

droptype.DataBind();
droptype.Items.Insert(0, new ListItem("--Select--", "0"));
}
catch (SqlException ex)
{
ex.Message.ToString();
}

---------------------------

SQL

con.Open();
            qry = "insert into dtdc_ititemmaster (Machine_Sr_no,Model,Type,Make,AMC_Date,Warranty_Date,Dept,User_Name,Identification,IP,Configuration,AMC_Vendor,PO_NO,PO_Date,Remarks) values('" +txtmachineno.Text+ "','" + txtmodel.Text  + "','" + droptype.SelectedItem + "','" + txtmake.Text + "','" + txtamc.Text+ "','" + txtwrrwnty.Text + "','" +dropdept.SelectedItem + "','"+txtuname.Text+"','"+txtidenty.Text+"','"+txtipadd.Text+"','"+txtconfg.Text+"','"+txtamcvndr.Text+"','"+txtpono.Text+"','"+txtpodate.Text+"','"+txtremark.Text+"')";
            SqlCommand cmd = new SqlCommand(qry, con);
            cmd.ExecuteNonQuery();

con.close();

Posted 17-Nov-14 3:01am

Member 11240491

Add a Solution

Comments

Richard Deeming 17-Nov-14 10:04am

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2014-11-17T03:09:00

You need to check for IsPostBack in the Page_Load event. If you put some breakpoints you would see what is happening. When you click the button (or whatever you have) to save the value back into the database the Page_Load event runs first and so you rebind the dropdown losing the value that the user selected.

Do this instead in your Page_Load

C#

protected void Page_Load(object sender, EventArgs e)
   {
      // only want to do this the first time the page loads, not during postbacks
      if (!IsPostBack)
      {
         Bindtype();
      }       
   }

Also change your SQL to use parameters so you are not vulnerable to sql injections.

Member 11240491 · Answer 2 · 2014-11-17T23:54:00

Solution 3

i am using asp:content page it is no working,,

but it is working on under html pages how can is use in asp:content pages

Posted 17-Nov-14 23:54pm

Member 11240491

Dusara Maulik · Answer 3 · 2014-11-17T03:49:00

Hi,

Change your SQL as below:

To get value of selected item from dropdown in asp.net, you need to user dropdown.SelectedItem.value.

SQL

con.Open();
qry = "insert into dtdc_ititemmaster (Machine_Sr_no,Model,Type,Make,AMC_Date,Warranty_Date,Dept,User_Name,Identification,IP,Configuration,AMC_Vendor,PO_NO,PO_Date,Remarks) values('" +txtmachineno.Text+ "','" + txtmodel.Text  + "','" + droptype.SelectedItem.value + "','" + txtmake.Text + "','" + txtamc.Text+ "','" + txtwrrwnty.Text + "','" +dropdept.SelectedItem.value + "','"+txtuname.Text+"','"+txtidenty.Text+"','"+txtipadd.Text+"','"+txtconfg.Text+"','"+txtamcvndr.Text+"','"+txtpono.Text+"','"+txtpodate.Text+"','"+txtremark.Text+"')";
SqlCommand cmd = new SqlCommand(qry, con);
cmd.ExecuteNonQuery();

drodown list selected item unable to insert into sql inserting only first item as default, can any one help plz

3 solutions

Solution 1

Solution 3

Solution 2

Add your solution here

Preview 0