my data does not get retrieved

Question

1.00/5 (3 votes)

See more:

C#

protected void Submitbtn_Click(object sender, EventArgs e)
{
   string connection_string = @"Provider=Microsoft.Jet.OLEDB.4.0;
   Data Source=C:\HILProject\project4\App_Data\adminlog.mdb";

   using (OleDbConnection cn = new OleDbConnection(connection_string))
   {
      cn.Open();

      String str = "select Nationality, Post from BasicDtl_tbl where UserName=" + usertxt.Text;
      OleDbCommand cmd = new OleDbCommand(str,cn);
      // cmd.Connection = cn;
      OleDbDataAdapter ad = new OleDbDataAdapter(cmd);
      System.Data.DataSet ds = new System.Data.DataSet();
      try
      {
         ad.Fill(ds);
 
         Nattxt.Text = ds.Tables[0].Rows[0].ItemArray[3].ToString();
         apldposttxt.Text = ds.Tables[0].Rows[0].ItemArray[4].ToString();
         cn.Close();
      }
      catch(Exception)
      {
         StatusLabel.Text = "error occured";
      }
   }
}

data does not get retrieved

Posted 4-Jun-14 1:19am

Ashwini Thakare

Updated 4-Jun-14 1:49am

Nelek

v3

Add a Solution

Comments

Nirav Prabtani 4-Jun-14 7:21am

what is error???
try to debug code.. :)

[no name] 4-Jun-14 7:34am

You are missing single quotes for your user name. But you should be using parameterized queries instead as you have already been told.

Ajith K Gatty 4-Jun-14 9:14am

You are reposted your question again with little changes. But your query is again wrong exactly like your previous post.Use ' and " properly. Check that last post please. Just fix it first. Then debug. Good Luck.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-06-04T01:24:00

There are so many possibilities, but start with your SQL: Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

In your case, any "odd" character in the username, such as a space will also cause problems!

The chances are your problem will be resolved by using paramaterized queries, but personally I'd do a sanity check to make sure that the DataAdapter actually returned at least one row of at least one table before I started using them...that might help you as well.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Answer 2 · 2014-06-04T01:23:00

Solution 1

After the below line, while debugging, check if the DataSet actually contains data or not.

One more important thing is that you don't need to Open and Close the Connection when you use DataAdapter, as it implicitly Opens and Closes the Connection for you.

Posted 4-Jun-14 1:23am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Ashwini Thakare · Answer 3 · 2014-06-04T04:56:00

C#

protected void basic()
{
        bool temp = false;
        string connection_string = @"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=C:\HILProject\project4\App_Data\adminlog.mdb";
        using (OleDbConnection cn = new OleDbConnection(connection_string))
        {
            cn.Open();
            String str = "select Nationality, Post from BasicDtl_tbl where UserName='" + usertxt.Text.Trim() + "'";
            OleDbCommand cmd = new OleDbCommand(str, cn);
            cmd.Connection = cn;
            OleDbDataReader dr = cmd.ExecuteReader();
            while (dr.Read())
            {
                Nattxt.Text = dr.GetString(0);
                apldposttxt.Text = dr.GetString(1);
                temp = true;
            }
            if (temp == false)
                StatusLabel.Text = "error occured";
            cn.Close();
        }
    }

[Edited]:Set Language Tag

my data does not get retrieved

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0