Am I doing this right, if statments

Question

0.00/5 (No votes)

See more:

Hi All,

I need to check if this statement is right in the C family it would be:

C++

if(cbkSkipCurrentTest.Checked != True)
{
do tests
}

or the if the check box is not clicked 'do tests' if it is skip them the
VB version is

VB

If (cbkSkipCurrentTest.Checked = Not (True)) Then

or is it

VB

If (cbkSkipCurrentTest.Checked <> True) Then

They both appear to be the same from my point of view but...
Now on to the next Question

VB

If (RFcurrent > RFfreqLowCurrentHigh) Or (RFpower > RFfreqLowPwrMax) Then
                    RFtestBool = True
                    'MsgBox("Here!!")
                    If TestFailed() = True Then Exit Sub
                End If

If I change it to

VB

If (cbkSkipCurrentTest.Checked <> True) Then
               If (RFpower > RFfreqLowPwrMax) Then
                    RFtestBool = True
                    'MsgBox("Here!!")
                    If TestFailed() = True Then Exit Sub
                End If 
           Else

               If (RFcurrent > RFfreqLowCurrentHigh) Or (RFpower > RFfreqLowPwrMax) Then
                   RFtestBool = True
                   'MsgBox("Here!!")
                   If TestFailed() = True Then Exit Sub
               End If
           End If

Will that work properly?

Glenn

Posted 25-Apr-14 0:07am

glennPattonWork3

Updated 25-Apr-14 0:18am

v2

Add a Solution

2 solutions

Solution 1

I personnaly tend to prefer the

VB

If (cbkSkipCurrentTest.Checked)
   '' ...
End If

or

VB

If Not(cbkSkipCurrentTest.Checked)
   '' ...
End If

version.

In C#, that would give

C#

if (cbkSkipCurrentTest.Checked) {
   // ...
}

and

C#

if (!cbkSkipCurrentTest.Checked) {
   // ...
}

But this could be seen as a personnal choice; as Checked property already is a boolean value, I don't see the point to compare it to true or false; just use it as is, there is nothing more you need.

Hope this helps :)

Posted 25-Apr-14 0:18am

phil.o

Comments

glennPattonWork3 25-Apr-14 6:21am

Thanks...

Peter Leow 25-Apr-14 6:27am

Good advice. 5ed!

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2014-04-25T00:37:00

Answer to second question:

Yes, it will work properly. Though it could be simplified to:

VB

If Not(cbkSkipCurrentTest.Checked) Then
   If (RFpower > RFfreqLowPwrMax) Then
      RFtestBool = True
      'MsgBox("Here!!")
      If TestFailed() Then Exit Sub
   End If
Else
   If (RFcurrent > RFfreqLowCurrentHigh) Or (RFpower > RFfreqLowPwrMax) Then
      RFtestBool = True
      'MsgBox("Here!!")
      If TestFailed() Then Exit Sub
   End If
End If

Which gains in conciseness and clarity, IMHO.