How do I write a "If Condition" differently

Question

0.00/5 (No votes)

See more:

Hi,

My code has a IF condition where I am checking if a particular value falls between a set of integers (like 26,34,58,112 etc). I have written them through a OR operator (||) however it becomes a long statement to view.

The example of the code can be this way..

If (StatusOfCondition = "26") || (StatusOfCondition = "28") || (StatusOfCondition = "34") etc etc

Is there any other way through which I can write a loop and make it shorter?

Any help is appreciated.

Posted 20-Apr-14 21:08pm

gpthakur

Add a Solution

Comments

ccalma 21-Apr-14 3:29am

What is the source of the set of integers? You can create a list of integers, then use Contains method to check if the value exists in the list.

2 solutions

Solution 2

There are quite a lot of ways you can do that: particularly if you set up an array or list of "allowed values" - which can be a static readonly list.

The first is to use a switch instead:

C#

string StatusOfCondition = "26";
switch (StatusOfCondition)
    {
    case "26":
    case "28":
    case "34":
        // Do something
        break;
    default:
        // Do something for non matching values
        break;
    }

The framework can optimise switches pretty well.
The array version may be better though:

C#

private static readonly string[] allowedValues = new string[] { "26", "28", "34" };

    ...
    string StatusOfCondition = "26";
    if (allowedValues.Contains(StatusOfCondition))
        {
        ...
        }

Posted 20-Apr-14 21:27pm

OriginalGriff

Comments

DamithSL 21-Apr-14 3:33am

switch again will be lengthy option but my 5 for the array solution

OriginalGriff 21-Apr-14 3:46am

It's fairly long to write - but it is clear and obvious: you don't need to look elsewhere to check what values are allowed. And .NET can optimise it to a faster check than the array method.

Emre Ataseven 21-Apr-14 10:51am

5 for switch case. Provides readability and lower complexity. Average case complexity of array search O(logn) while switch jump O(1), if speed matters. And what if you decide to do different things if value is in set {56,78,56}, create another array? Switch-case rocks! :)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DamithSL · Accepted Answer · 2014-04-20T21:25:00

Solution 1

C#

// create list of integers with all options like below  
var list = new List<int> {26,34,58,112};
var StatusOfCondition = 58; // for testing..
//you can simple use Contains method like below 
if(list.Contains(StatusOfCondition))
{
  // do something 
}

Posted 20-Apr-14 21:25pm

DamithSL

Updated 20-Apr-14 21:28pm

v3

Comments

gpthakur 23-Apr-14 3:00am

Hi, this solution seems to work. I am doing a round of testing to be sure this is the final way to go. Thanks a lot for your help