Stored procedue appending ? is it right

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

SQL

SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER proc [dbo].[sp_Category122] @id int,@mode char(1)
as
declare @query varchar(5000)
set @query = 'Select * from quest_categories where cat_id = ' + convert(varchar(max),@id)
if @mode ='a'
	begin	
		declare @query1 varchar(5000)
		set @query1=' and cat_name = ''sql'''
		set @query = @query + @query1
	end
Exec(@query)
print(@query)

http://xneuron.wordpress.com/2007/12/05/reusable-data-layer-in-c/

Posted 21-Feb-11 0:38am

pnc.chandraprakash

Updated 22-Feb-11 23:03pm

v3

Add a Solution

Comments

Sunasara Imdadhusen 21-Feb-11 6:40am

Added code formatting!!

Prerak Patel 21-Feb-11 6:54am

seems ok. do you get any errors? what is the problem?

Manfred Rudolf Bihy 21-Feb-11 8:54am

Depends on what you're trying to achieve. What is the exact semantic of mode being equal to 'a'?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Costica U · Answer 1 · 2011-02-21T02:44:00

Solution 1

In order to avoid sql injection I would write something like this:

SQL

ALTER proc [dbo].[sp_Category122] @id int,@mode char(1)
as
declare @query nvarchar(4000)
set @query = 'Select * from quest_categories where cat_id = @id'
if @node='a'
   set @query = @query + ' and cat_name=''sql'''
---
exec sp_executesql @query, N'@id int', @id

Posted 21-Feb-11 2:44am

Costica U

Comments

Yusuf 21-Feb-11 8:57am

Good answer

_Ashish 1-Mar-11 3:27am

Good point

Manas Bhardwaj · Answer 2 · 2011-02-21T03:04:00

Solution 2

tried to get rid of dynamic sql

SQL

SELECT
    *
FROM
    quest_categories
WHERE
    cat_id = @id
    AND ((@mode = 'a' AND cat_name = 'sql') OR @mode <> 'a'))

Posted 21-Feb-11 3:04am

Manas Bhardwaj

Updated 21-Feb-11 3:33am

v2