dono insert value in window form

Question

0.00/5 (No votes)

See more:

Dear i m unable to insert in table . here i m using windowform and sql data base .

i use following code :

add user this is connection string :

C#

SqlConnection con = new SqlConnection("Data Source=RIZM9\\SQLEXPRESS; Initial Catalog=DynamicDB; integrated security= true; Timeout=45;");

string qry = "INSERT INTO User (Name,Mobile,EmailId,Gender) VALUES( '" + textBox1.Text + "' , '" + textBox2.Text + "','" + textBox3.Text + "' , '" + genderText + "')";
           
SqlCommand cmd = new SqlCommand(qry, con);
cmd.ExecuteNonQuery();
con.Close();
MessageBox.Show("Inserted Successfully");
this.Hide();

But Value not INserted in table . plz help me how to insert data in window form .

Posted 27-Jan-14 1:47am

Rohit85

Updated 27-Jan-14 1:49am

Richard MacCutchan

v2

Add a Solution

Comments

Richard MacCutchan 27-Jan-14 7:51am

You are using the wrong method for your SQL command, Google for "bobby tables" and learn how to protect yourself from SQL injection attacks and the loss of your database. You should also add code to check for successful execution/completion of your commands.

Rohit85 27-Jan-14 7:56am

plz give me suggestion with code how to insert successfully

Karthik_Mahalingam 27-Jan-14 7:58am

r u getting any error ?

Rohit85 27-Jan-14 8:06am

Incorrect syntax near the keyword 'User'.

Karthik_Mahalingam 27-Jan-14 8:11am

check my solution

Rohit85 27-Jan-14 8:19am

Thanks But I want to User Id Code generate manually How it will be possible . Like U_001

Karthik_Mahalingam 27-Jan-14 8:27am

as we are moving out of the topic,
you can post a new question. with detailed description of it. so that many will get notification and reply on that...
Thanks
karthik

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2014-01-27T02:10:00

Solution 1

try this

C#

string qry = "INSERT INTO  [dbo].[user] (Name,Mobile,EmailId,Gender) VALUES( '" + textBox1.Text + "' , '" + textBox2.Text + "','" + textBox3.Text + "' , '" + genderText + "')";

Note: be aware of SQL Injection[^]

updated based on thebelow comments:

C#

string qry = "INSERT INTO [dbo].[User] (Name,Mobile,EmailId,Gender) VALUES( @Name,@Mobile,@EmailId,@Gender)";

           SqlCommand cmd = new SqlCommand(qry, con);
           cmd.Parameters.AddWithValue("@Name", textBox1.Text);
           cmd.Parameters.AddWithValue("@Mobile", textBox2.Text);
           cmd.Parameters.AddWithValue("@EmailId", textBox3.Text);
           cmd.Parameters.AddWithValue("@Gender", genderText);
           cmd.ExecuteNonQuery();

Posted 27-Jan-14 2:10am

Karthik_Mahalingam

Updated 27-Jan-14 3:11am

v3

Comments

Richard MacCutchan 27-Jan-14 8:44am

Don't use string concatenation for SQL commands. See my first comment above.

Rohit85 27-Jan-14 8:58am

than what should be use here ? i m inserting this for single stand alone software for small uses in personal updates

Richard MacCutchan 27-Jan-14 9:03am

Use parameterised queries. It will help you to avoid problems in the future, and will also make it much easier to diagnose and fix problems.

Rohit85 27-Jan-14 9:06am

Dear sir , i m very new for c# development filed . i donot have not more knowledge , plz give me some code help . like examples or sample of code in window froom field and .cs page code

Karthik_Mahalingam 27-Jan-14 9:12am

Rohit,
check my updated solution.

Richard MacCutchan 27-Jan-14 9:35am

As well as Karthik's solution you can find lots of useful articles at http://www.codeproject.com/script/Articles/Latest.aspx, http://www.w3schools.com/sql/default.asp and by making use of Google.