need to loop over the pictures

Question

0.00/5 (No votes)

See more:

I'm trying to make a Program which user Could Attach Pictures,And All Is Saved In Database Under One Id ,The Below Code Is Running Correctly But I Need To Let The User Have The Availability To add more than one pic in the same window , and when he attach a photo a label link is created with labellink.text = openfileDialog.Filename;

here is the code

private void add_photos_Click(object sender, EventArgs e)
        {   
            DBClass db = DBClass.GetInstance(); //this is a class which contains all commands of database and the connection

            add_new_content aa = (add_new_content)this.Owner;
            string id = @"select cont_id from dbo.contents where cont_name='" + aa.txt_name.Text + "'";
            object obj = db.ExecuteScalre(id,CommandType.Text);


            string str = @"INSERT INTO [Picture_upload].[dbo].[Pictures]
           ([cont_id]
           ,[path])
            VALUES
           (" + obj + ",'" +
              openFileDialog1.FileName + "')";
            

            db.ExecuteNonQuery(str, CommandType.Text); // i want to loop it

            linkLabel1.Text = openFileDialog1.FileName;  //i want to loop this too
            txt_link.Text = " ";



     }

Posted 12-Jan-14 1:24am

Member 10518995

Updated 12-Jan-14 2:08am

v5

Add a Solution

Comments

OriginalGriff 12-Jan-14 7:28am

This is not a good question - we cannot work out from that little what you are trying to do.
Remember that we can't see your screen, access your HDD, or read your mind.
So what do you want in the loop, and what does that have to do with your button click event?
Use the "Improve question" widget to edit your question and provide better information.

Member 10518995 12-Jan-14 7:39am

Thanks soo much for your quick replay and i'll try harder to improve my questions more

OriginalGriff 12-Jan-14 7:44am

Just do us both a favour: edit it again, and move the question out of the subject and into the body - where it isn't truncated and unreadable!
The subject should be a short description (ten words or so, max) which tells us enough to know if we have experience with the area. The body can be long enough to fully describe the problem.

Andreas Gieriet 12-Jan-14 7:54am

So what is the problem?
Some (DB-) design or implementation issue?
Compilation or functional problem?
Is this a homework assignment you ask us to do for you?
...?

The Title of your question is so unspecific that you risk nobody will answer - the question must attract those CP members who potentially know an answer. If you don't manage to provide a concise question title, then at least add the relevant terms in the subject, e.g. "How to add multiple pictures to database?"

Cheers
Andi

Member 10518995 12-Jan-14 7:57am

i just don't know how to make a loop for btn_click
while(btn_click)
{
do code..
}

Andreas Gieriet 12-Jan-14 8:03am

GUI systems are not "polling" systems, but rather "event-base" systems. I.e. you have events to which you register to be notified when the event happens.
E.g. your btn_click handler function is most likely already registered to the button click event of the respective button. So, the function is called once when you click the button. Within that function you now need to loop over the pictures and do something useful with them.

Or if you have a button for each picture, each picture needs to have its individual btn_XXX_Clicked handler. It's not clear from what you wrote so far.

But again, please update the title of the question.

Cheers
Andi

Member 10518995 12-Jan-14 8:11am

no i don't have a button for each pic its just one button , add all pictures i've selected in my db
but actually this code add only one pic

Andreas Gieriet 12-Jan-14 8:21am

What objects hold the pictures to be stored in the DB?

Member 10518995 12-Jan-14 8:28am

i don't know what you mean ?
i get the pic from openfiledialog , and saved under openfiledialog.filname and sved in database in entity called path varchar type in a table called pictures

class DBClass{
public void ExecuteNonQuery(string Query, CommandType type)
{

OpenConnection();
cmd.CommandText = Query;
cmd.CommandType = type;
try
{
cmd.ExecuteNonQuery();
}
catch(Exception ex)
{

}
finally
{
ReleaseResource();
}
private void OpenConnection()
{
try
{
this.connection.Open();
}
catch
{ }
}

}

Member 10518995 12-Jan-14 8:33am

DBClass db = DBClass.GetInstance();
string str = @"INSERT INTO [Picture_upload].[dbo].[Pictures]
([cont_id]
,[path])
VALUES
(" + obj + ",'" +
openFileDialog1.FileName + "')";
db.ExecuteNonQuery(str, CommandType.Text);

Andreas Gieriet 12-Jan-14 8:34am

I think OriginalGriff answers your question. See solution #1.
Cheers
Andi

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-01-12T02:31:00

Looking at your comments on your question, it looks like you want each time he presses the button to add a file to the db - in which case you don't want a loop at all: you will get a Click event each time he presses the button, so do one each time he presses it.

Then, the only complications are:
1) You need to activate your OpenFileDialog in the click handler to get a new file:

C#

if (openFileDialog1.ShowDialog() == DialogResult.OK)
   {
   DBClass db = DBClass.GetInstance();
   ...
   }

Though I would probably create the OpenFileDialog instance as part of the event handler, rather than embedding one in my form.
2) You need to look at adding a new LinkLabel each time he clicks - if you just recycle the existing one then you can only show the last file link. However, you need to work out where you are going to put them - I can't do that for you - but the general code is:

C#

OpenFileDialog ofd = new OpenFileDialog();
if (ofd.ShowDialog() == DialogResult.OK)
    {
    LinkLabel ll = new LinkLabel();
    ll.Text = ofd.FileName;
    ll.Location = new Point(100, 100);
    Controls.Add(ll);
    }

You will need to set the location to your point (which shouldn't be the same each time...) and you probably need to hook up some events as well.
3) You should look at your database code as well: Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.