doubt in asp.net please solve it

Question

0.00/5 (No votes)

See more:

my page is like this,
CompanyName (here is a textbox id:TextBox9cmpynam)
view CompanyProfile(button)
when we click this button the data from database must displayed in the corresponding textbox..any one can correct my code...

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Configuration;
using System.Data;



public partial class viewcompanyprofile : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {

    }

    protected void Button1_Click1(object sender, EventArgs e)
    {
        SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["CRegConnectionString"].ConnectionString);
        SqlCommand com = new SqlCommand("select * from CompanyProfile where CompanyName'" + TextBox9cmpynam.Text + "'", con);
        SqlDataAdapter da = new SqlDataAdapter(com);
        con.Open();
        DataSet ds = new DataSet();
        string cmdStr = "select count(*) from CompanyProfile where CompanyName='" + TextBox9cmpynam.Text + "'";
        SqlCommand User = new SqlCommand(cmdStr, con);
        int temp = Convert.ToInt32(User.ExecuteScalar().ToString());
        con.Close();
        if (temp == 1)
        {
           try
            {

                Panel1.Visible = true;
                com.ExecuteNonQuery();
                da.Fill(ds, "CompanyProfile");
                TextBox1cmpynm.Text = ds.Tables["CompanyProfile"].Rows[0]["CompanyName"].ToString();
                TextBox2briefprofle.Text = ds.Tables["CompanyProfile"].Rows[0]["BriefProfile"].ToString();
                TextBox3addr.Text = ds.Tables["CompanyProfile"].Rows[0]["Address"].ToString();
                TextBox4state.Text = ds.Tables["CompanyProfile"].Rows[0]["State"].ToString();
                TextBox5country.Text = ds.Tables["CompanyProfile"].Rows[0]["Country"].ToString();
                TextBox6phno.Text = ds.Tables["CompanyProfile"].Rows[0]["PhoneNo"].ToString();
                TextBox7website.Text = ds.Tables["CompanyProfile"].Rows[0]["Website"].ToString();
                TextBox8emailid.Text = ds.Tables["CompanyProfile"].Rows[0][""].ToString();
                con.Close();
            }
            catch (Exception er)
            {
                Response.Write("Something really bad happend .....Please try again");
            }
        }
        else
        {

            Panel1.Visible = false;

        }
    }
}

when i executed this code there is no error .but it is not displaying the data from database to textbox

Posted 24-Dec-13 20:53pm

Member 10467514

Updated 24-Dec-13 20:55pm

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v2

Add a Solution

Comments

JoCodes 25-Dec-13 3:26am

Have check the same sql query in Query Analyzer ?. Execute it and check whether it returns any rows in the DB..

Member 10467514 25-Dec-13 3:33am

Query Analyzer??...I am A fresher in this field.......

JoCodes 25-Dec-13 3:50am

Its just to execute the sql query in the sqlserver query analyser window to check the sql statement works fine or not.

3 solutions

Solution 2

you make a Store Procedure and call to one by one. your code is very confused crate.You make sure your sql Query is work fine. Once again try with the help of Brake Point and check line by line. for more information try this link http://csharp.net-tutorials.com/debugging/breakpoints/[^]

Posted 24-Dec-13 21:13pm

joginder-banger

Comments

Member 10467514 25-Dec-13 3:31am

can you please say how to add a checkbox to the exsisting gridview.........

joginder-banger 25-Dec-13 4:02am

<asp:GridView ID="GridView1" runat="server" AutoGenerateColumns="False">
<columns>
<asp:TemplateField>
<itemtemplate>
<asp:CheckBox ID="CheckBox3" runat="server" />

<emptydatatemplate>
<asp:CheckBox ID="CheckBox2" runat="server" />

Solution 3

Try

 SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["CRegConnectionString"].ConnectionString);
    SqlCommand com = con.CreateCommand();
    com.CommandText ="select * from CompanyProfile where CompanyName'" + TextBox9cmpynam.Text + "'";
    con.Open();
SqlDataAdapter da = new SqlDataAdapter(com);
        con.Open();
        DataSet ds = new DataSet();
	da.Fill(ds,"CompanyProfile");
    int temp = ds.Tables[0].Rows.Count;
    if (temp == 1)
        {
		//Logic based on condition
	}

    con.Close();

Note that Tadit , already has pointed out that you missed to fill your Dataset .
Also, avoid inline queries which are open to SQL injections.

Hope this helps...

Posted 24-Dec-13 21:48pm

JoCodes

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2013-12-24T21:04:00

Solution 1

Please don't use inline queries, it opens your code to Sql Injection attack.

So, change the following query...

C#

string cmdStr = "select count(*) from CompanyProfile where CompanyName='" + TextBox9cmpynam.Text + "'";

to...

C#

string query = "select * from CompanyProfile where CompanyName=@CompanyName";

SqlCommand cmd = new SqlCommand(query, con);
cmd.Parameters.AddWithValue("@CompanyName", TextBox9cmpynam.Text);

After that debug your code and find if there are any rows present in the DataSet ds when the following code line executes..

C#

da.Fill(ds, "CompanyProfile");

[Update]
Use the below code...

C#

protected void Button1_Click1(object sender, EventArgs e)
{
    SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["CRegConnectionString"].ConnectionString);
    
    string query = "select * from CompanyProfile where CompanyName = @CompanyName";
    SqlCommand cmd = new SqlCommand(query, con);
    cmd.Parameters.Add(new SqlParameter("@CompanyName", TextBox9cmpynam.Text.Trim()));
    
    SqlDataAdapter da = new SqlDataAdapter(cmd);
    DataSet ds = new DataSet();     
    
    try
    {
    	da.Fill(ds, "CompanyProfile");
    
    	if(ds != null && ds.Tables["CompanyProfile"] != null && ds.Tables["CompanyProfile"].Rows.Count > 0)
    	{
    		Panel1.Visible = true;
    		
    		TextBox1cmpynm.Text = ds.Tables["CompanyProfile"].Rows[0]["CompanyName"].ToString();
    		TextBox2briefprofle.Text = ds.Tables["CompanyProfile"].Rows[0]["BriefProfile"].ToString();
    		TextBox3addr.Text = ds.Tables["CompanyProfile"].Rows[0]["Address"].ToString();
    		TextBox4state.Text = ds.Tables["CompanyProfile"].Rows[0]["State"].ToString();
    		TextBox5country.Text = ds.Tables["CompanyProfile"].Rows[0]["Country"].ToString();
    		TextBox6phno.Text = ds.Tables["CompanyProfile"].Rows[0]["PhoneNo"].ToString();
    		TextBox7website.Text = ds.Tables["CompanyProfile"].Rows[0]["Website"].ToString();
    		TextBox8emailid.Text = ds.Tables["CompanyProfile"].Rows[0][""].ToString(); // Here provide the Column Name.
    		con.Close();
    	}
    	else
        {
            Panel1.Visible = false;
        }
    }
    catch (Exception er)
    {
    		Response.Write("Something really bad happend .....Please try again");
    }    
}

Posted 24-Dec-13 21:04pm

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Updated 25-Dec-13 0:13am

v7

Comments

Member 10467514 25-Dec-13 3:16am

when i added the above command it shows error
sql exception handled
you must declare the @CompanyName
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Configuration;
using System.Data;

public partial class viewcompanyprofile : System.Web.UI.Page
{
protected void Page_Load(object sender, EventArgs e)
{

}

protected void Button1_Click1(object sender, EventArgs e)
{
SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["CRegConnectionString"].ConnectionString);
SqlCommand com = new SqlCommand("select * from CompanyProfile where CompanyName'" + TextBox9cmpynam.Text + "'", con);
SqlDataAdapter da = new SqlDataAdapter(com);
con.Open();
DataSet ds = new DataSet();
string query = "select count(*) from CompanyProfile where CompanyName=@CompanyName";

SqlCommand cmd = new SqlCommand(query, con);
cmd.Parameters.AddWithValue("@CompanyName", TextBox9cmpynam.Text);
SqlCommand User = new SqlCommand(query, con);
int temp = Convert.ToInt32(User.ExecuteScalar().ToString());
con.Close();
if (temp == 1)
{
try
{

Panel1.Visible = true;
com.ExecuteNonQuery();
da.Fill(ds, "CompanyProfile");
TextBox1cmpynm.Text = ds.Tables["CompanyProfile"].Rows[0]["CompanyName"].ToString();
TextBox2briefprofle.Text = ds.Tables["CompanyProfile"].Rows[0]["BriefProfile"].ToString();
TextBox3addr.Text = ds.Tables["CompanyProfile"].Rows[0]["Address"].ToString();
TextBox4state.Text = ds.Tables["CompanyProfile"].Rows[0]["State"].ToString();
TextBox5country.Text = ds.Tables["CompanyProfile"].Rows[0]["Country"].ToString();
TextBox6phno.Text = ds.Tables["CompanyProfile"].Rows[0]["PhoneNo"].ToString();
TextBox7website.Text = ds.Tables["CompanyProfile"].Rows[0]["Website"].ToString();
TextBox8emailid.Text = ds.Tables["CompanyProfile"].Rows[0][""].ToString();
con.Close();
}
catch (Exception er)
{
Response.Write("Something really bad happend .....Please try again");
}
}
else
{

Panel1.Visible = false;

}
}
}

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 25-Dec-13 3:46am

You have made it very complex.

I am updating my answer, use that. :)

Member 10467514 25-Dec-13 4:02am

sorry to tell that....it showing the panel containing textbox but not showing the correspoding company name profile details in textbox.textbox is showing empty.....

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 25-Dec-13 5:04am

Sorry, my mistake. There was a problem in query. There should not count(*).

It should be...

string query = "select * from CompanyProfile where CompanyName = @CompanyName";

But I would suggest you to write the Column Names separated by comma instead of *.

Now, I have updated the answer. It should work. Try and let me know.

Member 10467514 25-Dec-13 6:07am

now it is showing value only in the company name textbox...
my page is shown below
CompanyName (here is one textbox)
view my profile(button)

CompanyName (textbox)
BreifProfile (textbox)
Address (textbox)
State (textbox)
Country (textbox)
PhoneNo(textbox)
Website (textbox)
EmailID(textbox)
here when we click view button only Company Name is displaying...other textboxes are showing empty...

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 25-Dec-13 6:15am

Make sure the Column Names of Table you are trying to read are correct.
Are the Column Names correctly match with the Column Names in Database Table?
Please debug and see what all values are binding to the DataSet Table "CompanyProfile".

Member 10467514 25-Dec-13 9:10am

all column names are correctly spelled then also it is not showing the data...

Member 10467514 25-Dec-13 9:20am

showing that something really bad happend.....if i remove the try catch ,then it is throwing an exception that brief profile is not there in the table companyprofile....why it is showing like this?

Member 10467514 25-Dec-13 9:29am

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Configuration;
using System.Data;

public partial class viewcompanyprofile : System.Web.UI.Page
{
protected void Page_Load(object sender, EventArgs e)
{

}

protected void Button1_Click1(object sender, EventArgs e)
{
SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["CRegConnectionString"].ConnectionString);

string query = "select * from CompanyProfile where CompanyName = @CompanyName";
SqlCommand cmd = new SqlCommand(query, con);
cmd.Parameters.Add(new SqlParameter("@CompanyName", TextBox9cmpynam.Text.Trim()));

SqlDataAdapter da = new SqlDataAdapter(cmd);
DataSet ds = new DataSet();
try
{
da.Fill(ds, "CompanyProfile");

if (ds != null && ds.Tables["CompanyProfile"] != null && ds.Tables["CompanyProfile"].Rows.Count > 0)
{
Panel1.Visible = true;
TextBox1cmpynm.Text = ds.Tables["CompanyProfile"].Rows[0]["CompanyName"].ToString();
TextBox2briefprofle.Text = ds.Tables["CompanyProfile"].Rows[0]["BriefProfile"].ToString();
TextBox3addr.Text = ds.Tables["CompanyProfile"].Rows[0]["Address"].ToString();
TextBox4state.Text = ds.Tables["CompanyProfile"].Rows[0]["State"].ToString();
TextBox5country.Text = ds.Tables["CompanyProfile"].Rows[0]["Country"].ToString();
TextBox6phno.Text = ds.Tables["CompanyProfile"].Rows[0]["PhoneNo"].ToString();
TextBox7website.Text = ds.Tables["CompanyProfile"].Rows[0]["Website"].ToString();
TextBox8emailid.Text = ds.Tables["CompanyProfile"].Rows[0]["EmailID"].ToString();
con.Close();
}
else
{
Panel1.Visible = false;
}
}

catch (Exception er)
{
Response.Write("Something really bad happend .....Please try again");
}

}
}

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 25-Dec-13 12:27pm

As I said you, while debugging, check what all rows and columns are there in the DataTable. Do you know how to check? Just mouse hover on ds after the fill method execution, then see the row count of table CompanyProfile. You can also see the table and it's column. Check what all columns it is returning.

The code is throwing exception means that DataTable does not have that column.

Member 10467514 26-Dec-13 0:47am

Thanku so much sir it is working......

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 26-Dec-13 1:28am

Glad to hear that. :) Look, that is you who did this, I only guided you through out your work. So, do have confidence in yourself and keep coding like that.

Thanks,
Tadit