HOW i can write this program in a correct way?

Question

1.00/5 (1 vote)

See more:

C#

#include "stdafx.h"
#include "stdafx.h"
#include <iostream>
#include <string>
using namespace std;
int jomleTokalame(string *a){
    string s = "";
int count = s.length();
string::iterator i;
int Count = 0;
for (i = s.begin(); i != s.end(); i++)
{
    if(*i != ' ' && *i != '.')
    {
        Count++;
    }
}
cout<<Count<<endl;
}
int main()
{
    string a;
    string s="salam";
    int g;
    cout<<jomleTokalame()<<endl;
}

Posted 13-Feb-11 4:19am

mf_arian

Updated 13-Feb-11 5:17am

Sergey Alexandrovich Kryukov

v5

Add a Solution

Comments

Manfred Rudolf Bihy 13-Feb-11 10:21am

So where is your problem? What is your issue? Please be more specific of what is going on. Thanks!

Manfred Rudolf Bihy 13-Feb-11 10:26am

Edit: Removed superflous pre tag. Added one closing curly parenthesis "}". Added proper indentation for readability.

Nish Nishant 13-Feb-11 10:27am

Good that someone's paying attention to the details, the OP certainly is not :-)

Sergey Alexandrovich Kryukov 13-Feb-11 11:18am

The superflous pre tag was still there. One more?
--SA

mf_arian 13-Feb-11 11:34am

i donnot know what do you say?

Manfred Rudolf Bihy 13-Feb-11 12:21pm

After you reedited the changes I made you reintroduced the superflous pre tag. Compare the revisions and you'll get it.

Sergey Alexandrovich Kryukov 13-Feb-11 14:25pm

I removed the superflous pre tag. It is OK now? Before I edited it wasn't, no matter who did it.
--SA

Manfred Rudolf Bihy 13-Feb-11 14:29pm

I'm sorry I have to insist on this, but if you click on the link "Revision X" beneath the question you'll get to a screen where you can see and compare all revisions that were made to the question. After my edit the superfluous pre tag was removed. Check yourself if you don't believe me. :)

Manfred Rudolf Bihy 13-Feb-11 11:59am

SA you have to check the revision I made. After that OP did a redit and reintroduced the superfluous pre tag. I guess they'll never learn! :))

Sergey Alexandrovich Kryukov 13-Feb-11 14:25pm

Maybe, who cares?
Thank you anyway for payning so much attentions.
--SA

Sergey Alexandrovich Kryukov 13-Feb-11 14:27pm

What really matters, nothing helps O. "jomleTokalame" P. so far.
--SA

3 solutions

Solution 1

While editing the code you had posted I found that there was a missing closing brace (curly parenthesis). Was that your problem? Did you receive any compilation errors?

Regards.

Posted 13-Feb-11 4:25am

Manfred Rudolf Bihy

Updated 13-Feb-11 4:26am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nish Nishant · Accepted Answer · 2011-02-13T04:26:00

Solution 2

Wow, that code will not even compile. c is an int variable. So you cannot access it like a pointer/array as you have in that code. That's just the most glaring error in the code, I am sure there are other problems too.

Can you restate exactly what it is you are trying to do here?

[Edit]
~~~~~~~~

If you just want the length of your string, it's just one line of code to do that:

C++

string s = "test";
int count = s.length();

[Edit 2 ]
~~~~~~~~~~

Based on your updated requirements not to include space and dot, here's what you can do:

C++

string s = "This is a test.";
int count = s.length();
string::iterator it;
int filteredCount = 0;
for (it = s.begin(); it != s.end(); it++)
{
    if(*it != ' ' && *it != '.')
    {
        filteredCount++;
    }
}

Posted 13-Feb-11 4:26am

Nish Nishant

Updated 13-Feb-11 4:42am

v3

Comments

mf_arian 13-Feb-11 10:37am

but i want that just count the char without space and dot

Nish Nishant 13-Feb-11 10:43am

I have updated my answer, please check it out.

Manfred Rudolf Bihy 13-Feb-11 10:40am

I was so busy formatting his code I didn't event read it fully. 5+
At least with the missing } fixed maybe OP will get some better error messages.

Nish Nishant 13-Feb-11 10:44am

Yeah, there are simply too many errors in the code that it's easier to just rewrite it.

Sergey Alexandrovich Kryukov 13-Feb-11 11:11am

My 5,
--SA

Nuri Ismail 13-Feb-11 11:29am

Good answer! 5+

Nuri Ismail · Accepted Answer · 2011-02-13T05:29:00

Solution 3

Nish's answer is excellent.
Alternatively you can use the standard std::count_if[^] algorithm.
Here is a quick example for you:

C++

#include <iostream>
#include <string>
#include <algorithm>

// We will use this filter pradicate with std::count_if
bool filter(char arg)
{
    // Accept all chars except spaces and dots
    return arg != ' ' && arg != '.';
}

int main()
{
    std::string str("Test test. Test test.");
    // Count the symbols in the string using filter
    std::cout << "Count: " << std::count_if(str.begin(), str.end(), filter);
    return 0;
}

You see that using the count_if algorithm could simplify things a lot. ;)

Posted 13-Feb-11 5:29am

Nuri Ismail

Updated 13-Feb-11 5:31am

v2

Comments

Nish Nishant 13-Feb-11 11:31am

Voted 5, great answer Nuri. I kept my response simple as the OP is quite a newbie, and STL style functions can often be overwhelming to newbies :-)

Nuri Ismail 13-Feb-11 11:41am

Yes Nish, I know that first clashes with STL can be scary for a newbie, but sometimes they motivate the new programmers to begin learning the STL. At least for me it was so. :)
That's why I decided to post this alternative answer. :)

Thank you very much for the vote! :)

Manfred Rudolf Bihy 13-Feb-11 11:58am

My 5+!

Nuri Ismail 13-Feb-11 12:04pm

Thanks a lot Manfred! :)