I want in my program when the answer is yes go to switch and do a work that i write there but it cannot

Question

0.00/5 (No votes)

See more:

<pre lang="xml">#include "StdAfx.h"
#include <iostream>
#include <sstream>
#include <algorithm>
#include <string>
#include <vector>
using namespace std;
int main()
{
char str[] ="10 input x";
char * pch;
pch = strtok (str," ,.-");
int i = 0;
while (pch != NULL)
{
  printf ("%s\n",pch);
  if((i == 1) && !strcmp( pch, "input"))
  {
    int accumulator =0;
    int memory[100];
    int counter=0;
    int opCode ;
    int operand ;
    int instructionRegister;
    for(int i=0;i<counter;i++){
        instructionRegister=memory[i];
        opCode =instructionRegister/100;
        operand =instructionRegister%100;
        switch ( opCode){
            case 10:
            cout<<"plz enter a number:\n";
            cin>>memory[operand];
            break;
        }
    }
  }else{
      cout<<"no"<<endl;
  }
  pch = strtok (NULL, " ,.-");
  i++;
}
    return 0;
}

:doh:

Posted 9-Feb-11 21:04pm

mf_arian

Updated 9-Feb-11 22:33pm

v4

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-02-09T21:11:00

Move your test.

At present, you start the tokenising:

C++

char str[] ="10 input x";
char * pch;
pch = strtok (str," ,.-");

Then you run through each token:

C++

while (pch != NULL)
{
  printf ("%s\n",pch);
  pch = strtok (NULL, " ,.-");
}

Then you try to check the second one:

C++

if(strcmp( pch++, "input"))
{
    cout<<"yes";
}

The problem is that by the time to check, you have run out of tokens completely...
Try this:

C++

char str[] ="10 input x";
char * pch;
pch = strtok (str," ,.-");
int i = 0;
while (pch != NULL)
{
  printf ("%s\n",pch);
  if((i == 1) && strcmp( pch, "input"))
  {
    cout<<"yes";
  }
  pch = strtok (NULL, " ,.-");
  i++;
}

That way, you check the second token against your match string while you can still get at it! :laugh:

Nuri Ismail · Accepted Answer · 2011-02-09T21:44:00

And here is a solution using The Standard C++ Library.

C++

#include <iostream>
#include <sstream>
#include <algorithm>
#include <string>
#include <vector>

int main()
{
    std::vector<std::string> vtokens;
    std::string str("10 input x");
    
    // Extract the tokens from string
    std::istringstream iss(str);
    std::copy(std::istream_iterator<std::string>(iss),
              std::istream_iterator<std::string>(),
              std::back_inserter< std::vector<std::string> >(vtokens));
    
    // Now "vtokens" contains all of the tokens from the initial string.
    // Your specific requirement was to check if the second token is "input",
    // Here you go:
    bool banswer = (vtokens.size() > 1) ? vtokens[1] == "input" : false;
    std::string str_answer(banswer ? "yes" : "no");
    std::cout << "Answer: " << str_answer << std::endl;
    
    // Optional: hold the screen to see the results
    std::cin.get();
    return 0;
}

I give you this as an alternative to your C style code.
It's a demonstration how can you avoid strtok and use standard algorithms, containers and streams in C++.

:)

[UPDATE]
The OP slightly changed his question and the answers (from me and from OriginalGriff) were for the original question.

To OP:
You are reading from uninitialized memory (see your int memory[100]; array) and you are using uninitialized variables (instructionRegister variable).
[/UPDATE]

I want in my program when the answer is yes go to switch and do a work that i write there but it cannot

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0