Copying a single node from XML

Question

0.00/5 (No votes)

See more:

I have a function in which it modifies an XML file by removing all the node other than the node with specified id. My code is:

C#

public static void myTry()
       {
           string pathname = @"c:\Run\itemsnew.xml";
           var xdoc = XDocument.Load(pathname);
           foreach (var item in xdoc.XPathSelectElements("/items/superitem/item[@id!='2']"))
           {
               item.Remove();
               xdoc.Save(pathname);
               //myTry();
           }

           //xdoc.Save(@"d:\itemsnew.xml");

           Console.ReadLine();
       }

What my problem is this loop is only getting executed once. That is, if i have 4 nodes with id's 1,2,3 and 4, the XML which i get after the program execution is an XML with 3 nodes having Id's 2,3 and 4 but I need the XML with a single node, ie, the node with id=2. If i call my function inside itself (like i have commented here in line 10) i get the desired result. But how else can i achieve the same? How should i code the loop so that the function removes all the nodes with id!=2 in a single call?

Posted 14-Sep-13 20:47pm

djay99

Add a Solution

Comments

Joezer BH 15-Sep-13 3:04am

Out or curiosity: Why would you want to save on each iteration (instead of at the end)?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

woopsydoozy · Accepted Answer · 2013-09-16T05:11:00

As Canny said, you should not save each time through your loop--you're doing too much work that way. But what's causing your problem is the Remove inside the loop--see http://msdn.microsoft.com/en-us/library/system.xml.linq.xnode.remove.aspx[^]

If removing is all you're doing, you don't need to loop, just remove:

C#

string pathname = @"d:\itemsnew.xml";
var xdoc = XDocument.Load(pathname);
xdoc.XPathSelectElements("/items/superitem/item[@id!='2']").Remove();
xdoc.Save(pathname);

If you are doing more inside the loop, then convert your element enumeration to a list using ToList, as the MS link describes.