How to execute update query using string bulider

Question

0.00/5 (No votes)

See more:

pls help me in this issue,thanks in advance
How to execute update query using string bulider in asp .net c#

C#

StringBuilder str = new StringBuilder();
str.Append("update common");
str.Append("set receiptno=" + no + "");
str.Append("where accountid=" + Accountid + "and id=" + i + "");
MySqlCommand command = new MySqlCommand(str.ToString(), con, tran);
command.ExecuteNonQuery();

Posted 3-Sep-13 2:29am

pankajgarg1986

Updated 3-Sep-13 2:36am

Thanks7872

v2

Add a Solution

Comments

[no name] 3-Sep-13 8:34am

Just like you are doing? Do you expect us to read your mind to know what errors you are getting? Don't you believe in space characters?

[no name] 4-Sep-13 4:34am

what is your problem....can you describe...

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maarten Kools · Answer 1 · 2013-09-03T02:35:00

Not entirely sure what exactly your problem is (you might want to describe that a next time), but StringBuilder does not add spaces, so you'll need to add those yourself. However, forget about using a StringBuilder to create your query. Using this technique makes your application vulnerable to SQL injection. Always use parameters to build your query. First of all, this is much easier and more readable, but most importantly, it's a lot safer! More info:

Parameterized Query for MySQL with C#[^]
Help me for MySqlCommand parameters in C#[^]

Simon_Whale · Answer 2 · 2013-09-03T03:07:00

Solution 2

You haven't stated what your problem actually is, but from this link MySqlCommand.ExecuteNonQuery[^]

I can say that your code is correct. But also I would follow ^Mo^'s suggestion as this will help you against SQL Injection

Updated

your for loop is creating one string that contains 161,953 update statements that are not terminated and then you try to execute it. Personally I would try something like this

C#

for (int i = 1; i <= 161953; i++)
{
 str.Append("update commonparmarth");
 str.Append("set receiptnoid=" + no + "");
 str.Append("where accountid=" + Accountid + "and commonparmarthid=" + i + "");
 no++;

 MySqlCommand command = new MySqlCommand(str.ToString(), con, tran);
 command.ExecuteNonQuery();

 str.clear();
}

Posted 3-Sep-13 3:07am

Simon_Whale

Updated 3-Sep-13 22:28pm

v2

Comments

pankajgarg1986 4-Sep-13 0:11am

here i am used for loop in it and
error is you have error in sql syntax check the manual that correspondence to your mysql server version to right syntax use near
for (int i = 1; i <= 161953; i++)
{

str.Append("update commonparmarth");
str.Append("set receiptnoid=" + no + "");
str.Append("where accountid=" + Accountid + "and commonparmarthid=" + i + "");
no++;

}
MySqlCommand command = new MySqlCommand(str.ToString(), con, tran);
command.ExecuteNonQuery();

pankajgarg1986 4-Sep-13 0:30am

friends pls help me in this issue,thanks in advance

Simon_Whale 4-Sep-13 4:28am

I have updated my answer