session variable comparison not working

Question

0.00/5 (No votes)

See more:

C#

if (Session["Type"].ToString().Equals("Admin", StringComparison.CurrentCultureIgnoreCase))
           {
               LinkButton_logout.Text = "Logout";
               Label_loggedin.Text = "Welcome " + Session["Alias"].ToString();
           }
           else if (Session["Type"] == null)
           {
               Response.Redirect("Default.aspx");
           }

link button text and label text not changing ...not even redirecting to default page

Posted 26-Aug-13 21:56pm

apoorv1988

Updated 26-Aug-13 22:06pm

CPallini

v2

Add a Solution

Comments

kishore sharma 27-Aug-13 5:06am

its my suggestion, when you are comparing any two strings always consider case sensitivity,
so check by changing
Session["Type"].ToString().ToUpper().Equals("Admin".ToUpper(),...............

3 solutions

Solution 4

First you should check against null then go for comparison. The code should look like

C#

string type = Session["Type"] as string;

if (null == type)
{
    Response.Redirect("Default.aspx", true);
}
if (type.Equals("Admin",StringComparison.OrdinalIgnoreCase))
{
    LinkButton_logout.Text = "Logout";
    Label_loggedin.Text = "Welcome " + Convert.ToString(Session["Alias"]);
}

Posted 26-Aug-13 22:47pm

S. M. Ahasan Habib

Solution 3

Try this

C#

if (Session["Type"] == null)
{
    Response.Redirect("Default.aspx");
}
else if(String.Equals(Convert.ToString(Session["Type"]), "Admin",StringComparison.OrdinalIgnoreCase))
{
    LinkButton_logout.Text = "Logout";
    Label_loggedin.Text = "Welcome " + Convert.ToString(Session["Alias"]);
}

Note: Before this code,check that your sessions have proper values to be handled.

Regards..:)

Posted 26-Aug-13 22:01pm

Thanks7872

Updated 26-Aug-13 22:40pm

v6

Comments

OriginalGriff 27-Aug-13 4:02am

Won't help! :laugh:
If the variable is null, then ToString will throw an error...

Thanks7872 27-Aug-13 4:37am

That's the reason i made a note at the end of the answer.

Thanks7872 27-Aug-13 4:39am

Updated.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-08-26T22:01:00

Solution 1

If Session["Type"] is null, then the attempt to call ToString on it will throw a "Null Reference" exception on the first if condition - which will terminate the operation.

Change the order of your tests - always check for null first, never last!

Posted 26-Aug-13 22:01pm

OriginalGriff