While Loop Problem in SqlReader

Question

0.00/5 (No votes)

See more:

C#

public void gridfill()
    {
        reader = obj.SelCommand("Select type as TYPE,convert(varchar, fromdate, 103) as FROMDATE,convert(varchar, todate, 103) as TODATE,reason as REASON from tbl_leave where userid=(Select userid from tbl_login where username='" + lbluser.Text + "') and convert(varchar, todate, 103)>(select CONVERT(VARCHAR(10), getdate(), 103))");
        while (reader.Read())
            {
                DataTable DT = new DataTable();
                DT.Load(reader);
                leaveGrid.DataSource = DT;
                leaveGrid.DataBind();
            }
    }

C#

public SqlDataReader SelCommand(string Command)
   {
       cmd = new SqlCommand(Command, con);
       dr = cmd.ExecuteReader();
       return dr;
   }

Here, I am trying to read value from a query and if read, then load the values to a datatable. But after reading first time, it is showing an error
:"Invalid attempt to READ when reader is closed"

Any help will be thankful

Posted 2-Feb-11 17:16pm

kishore Rajendran

Updated 2-Feb-11 17:27pm

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2011-02-02T17:25:00

You are using wrong way to fill datatable using Reader object. You don't need while to fill it like this OR you can use while but then extract specific values and add them to datatable till loop goes on, ones loop ends assign datatable to grid.

Try this way instead:

C#

using (SqlCommand myCommand = new SqlCommand(sql, myConnection))
    {
      myConnection.Open();
      using (SqlDataReader myReader = myCommand.ExecuteReader())
      {
        DataTable myTable = new DataTable();
        myTable.Load(myReader);
        myConnection.Close();
        return myTable;
      }
    }