Inserting identity column value from one table to another another table

Question

0.00/5 (No votes)

See more:

I have two table .. ImageTable and ImageDetails
ImageTable has two columns .. Sno which is identity and img which is varBinary. I am storing images in ImageTable in varBinary format.

I am inserting details in ImageDetails which also include a column called HoMakerId which is a foreign key to ImageTable's Sno. So everything i am inserting image into ImageTable i am also inserting the Sno of last inserted image in ImageDetails ... something like this
CLICK HERE[^]

SQL

GO
ALTER procedure [dbo].[sp_InsertImage]
@Image varbinary(max),
@Date datetime,
@Uploader int
as
Insert into ImageTable(img) values(@Image);


Insert into ImageDetails(makerid,createdon,homakerid) values(@Uploader,@Date,(select top 1 sno from imagetable order by sno desc))

Do you think i need another approach or this one is fine? Should i be using transactions?

Posted 19-Aug-13 7:22am

arbaaz jalil

Add a Solution

Comments

ali_heidari_ 19-Aug-13 13:25pm

do you have problem with your store procedure?

arbaaz jalil 19-Aug-13 13:26pm

No its working fine. I just want to know if i should use another approach to store sno of first table in second table's HoMakerId.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

pradiprenushe · Accepted Answer · 2013-08-19T07:32:00

Solution 1

Use @ScopeIdentity. Change sp like this

SQL

Insert into ImageTable(img) values(@Image);
DECLARE @Id INTEGER
SET @Id = SCOPE_IDENTITY()
Insert into ImageDetails(makerid,createdon,homakerid) values(@Uploader,@Date,@Id)

Refer this
http://technet.microsoft.com/en-us/library/ms190315.aspx
http://www.c-sharpcorner.com/UploadFile/rohatash/identity-and-scope_identity-in-sql-server-2012/

Posted 19-Aug-13 7:32am

pradiprenushe

Updated 19-Aug-13 7:35am

v3

Comments

arbaaz jalil 19-Aug-13 13:35pm

What do i owe you my friend?

pradiprenushe 19-Aug-13 13:41pm

Thanks for accepting answer. It is pleasure for me that answer is useful for you.

arbaaz jalil 19-Aug-13 13:43pm

I mean .. how can i pay you back?

pradiprenushe 19-Aug-13 13:45pm

Not needed its pleasure for me also that you got solution from me.