How I Can Improve Code (Best approach) Of ADO.NET ?

Question

1.60/5 (2 votes)

See more:

Hi Friends,

There is some code snippet below, please suggest me which approach is better.

Approach One:

C#

STNList = new List<STNforGCN>();
               while (reader.Read())
               {
                   STNList.Add(LoadSTN(reader));
               }
               this.Connection.Close();



 private STNforGCN LoadSTN(IDataReader reader)
        {
            STNforGCN stn = new STNforGCN();
            stn.STNID = Convert.ToInt32(reader["STNID"]);
            stn.STNNumber = reader["STNNumber"].ToString();
            stn.GeneratedForEntityID = Convert.ToInt32(reader["GeneratedForEntityID"]);
            stn.Value = Math.Round(Convert.ToDecimal(reader["VALUE"]), 2);
            stn.BrandName = reader["BrandName"].ToString();
            stn.StnStatus = reader["Status"].ToString();
            return stn;
        }

Approach Two:

C#

 STNforGCN stn=null;
while (reader.Read())
               {
              
            stn = new STNforGCN();
            stn.STNID = Convert.ToInt32(reader["STNID"]);
            stn.STNNumber = reader["STNNumber"].ToString();
            stn.GeneratedForEntityID = Convert.ToInt32(reader["GeneratedForEntityID"]);
            stn.Value = Math.Round(Convert.ToDecimal(reader["VALUE"]), 2);
            stn.BrandName = reader["BrandName"].ToString();
            stn.StnStatus = reader["Status"].ToString();
             STNList.Add(stn);
               }
               this.Connection.Close();

Posted 11-Jul-13 20:28pm

shreeniwas kushwah

Updated 11-Jul-13 20:34pm

Mohammed Hameed

v2

Add a Solution

Comments

Richard MacCutchan 12-Jul-13 3:42am

Better for what?

Deenuji 12-Jul-13 3:47am

elaborate your question????

maneavnash 12-Jul-13 3:47am

Approach One is better ....

shreeniwas kushwah 12-Jul-13 3:58am

If i use private method LoadSTN() then if list has 10000000 records then 10000000 objects of STN class created and if i use Approch two then single object initialize memory 10000000 times

then what is better approch????

shreeniwas kushwah 12-Jul-13 4:37am

can any one help me????

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Fredrik Bornander · Accepted Answer · 2013-07-11T22:42:00

Approach One is likely to be considered "better" by people. The reason for this is that its design is better with the creation of a STNforGCN object separated from iterating over the result list.

As for performance, they're about the same for all practical scenarios. You will have to pay the overhead of a method call per line in the result with approach one, but that is likely to be insignificant compared to the rest of the work carried out.

You are in both approaches allocating and initializing the same number of STNforGCN objects, the fact that Approach two re-uses a local variable saves at most moving the stack-pointer which is going to be very fast anyway.

If you're really concerned about performance you should use a profiler instead of guessing, modern compilers can do awesome things to your code so it is very difficult to determine absolute performance differences by just looking at the code. For example, if the compiler decides to inline LoadSTN in Approach One, then the solutions are pretty much identical.

Hope this helps,
Fredrik