am getting exception in update query

Question

3.00/5 (2 votes)

See more:

Hi,

am getting Syntax error in update query.

can any one help me.

C#

cmd.CommandText = "UPDATE SystemInfo SET" + " UserName='" + UserName + "', UserDomainName='" + UserDomainName + "',UserMachineName='" + UserMachineName + "',UserIP='" + UserIP + "', UserOsVersion='" + UserOsVersion + "',UserSystemDirectory='" + UserSystemDirectory + "',UserCurrentDirectory='" + UserCurrentDirectory + "', ProcessorName='" + ProcessorName + "', ProcessMnufacturer='" + ProcessMnufacturer + "',ProcessorID='" + ProcessorID + "',ProcessorDescription='" + ProcessorDescription + "',ProcessorVersion='" + ProcessorVersion + "',ProcessorStatus='" + ProcessorStatus + "',ProcessorDeviceId='" + ProcessorDeviceId + "', OSCaption='" + OSCaption + "',OSSerialNumber='" + OSSerialNumber + "',OSManufacturer ='" + OSManufacturer + "',OSVersion='" + OSVersion + "', OSStatus='" + OSStatus + "',OSName='" + OSName + "', BiosName='" + BiosName + "',BiosVersion='" + BiosVersion + "',BiosSerialNumber='" + BiosSerialNumber + "', BiosManufacturer='" + BiosManufacturer + "',BiosCurrentlanguage='" + BiosCurrentlanguage + "', BiosStatus='" + BiosStatus + "Where UserName=" + UserName;

Thanks Regards
sam.198979

Posted 17-Jun-13 0:10am

sam.198979

Add a Solution

Comments

Prasad_Kulkarni 17-Jun-13 6:12am

Can you show your table design?

[no name] 17-Jun-13 6:13am

"any one help me", sure use a parameterized query instead like you should be using anyway and your exception will likely go away and you get the extra added benefit of avoiding SQL injection attacks.

Mike Meinz 17-Jun-13 6:28am

You are missing several apostrophes. That said, it is a best practice to use the SQLParameter Class rather than concatenated string queries. Queries using the SQLParameter class perform better and are protected from SQL Injection Attacks.

See SQLParameter Class

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Amol_B · Accepted Answer · 2013-06-17T00:26:00

Last Statement

, BiosStatus='" + BiosStatus + "Where UserName=" + UserName;

should be like

, BiosStatus='" + BiosStatus + "' Where UserName='" + UserName+"'";

Added space and single quote before where keyword.
Please test yor query properly as it contain lot of variables involved.
Its always nice to use Parameters instead.