Queue + libsoup. Memory vioalation

Question

2.00/5 (3 votes)

See more:

I have problem with my program writed in c++, using libsoup and queue.

C++

void operator()()
{
    ELEMENT e;
    while(1)
    {
        if(!fq->empty())
        {

            mutex.lock();
            e = fq->front();


            run(server, &e);


            fq->pop();

            mutex.unlock();
        }

It works good before I add ExecuteLoop to make an queue. When I run it and start to make requests to the server I see memory vialation error. From time to time it gives me more information:

*** glibc detected *** ./fifo: double free or corruption (!prev): 

0x0a23e758 ***
======= Backtrace: =========
(...)

I have no idea where I make a mistake. Can you help me?

Posted 6-Apr-13 22:29pm

Member 8826489

Updated 21-May-13 4:57am

v7

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Matthew Faithfull · Accepted Answer · 2013-04-08T01:43:00

Solution 1

I don't claim to understand what all this is doing but consider these lines:

if(!fq->empty())
  {

      queue_mutex.lock();
      e = fq->front();

What happens if the the queue is not empty when the condition is tested but it is empty before the lock is asserted?
This can happen which is the same as to say it will happen. Perhaps you need to move the lock before the check or redo the check inside the lock?

Posted 8-Apr-13 1:43am

Matthew Faithfull

Comments

Matthew Faithfull 8-Apr-13 7:59am

Not sure in that case. I would start by confirming that the error occurs during the fq->pop(); call. Perhaps even comment that out to confirm it then doesn't crash although of course the fifo will fill up and the same message will get processed repeatedly. Anyway it seems like its claiming there's a pop from an empty queue which is wierd. Sorry I can't really help you futher.