Combining code to one routine? Can delegates in C# be used in such scenario?

Question

0.00/5 (No votes)

See more:

Routine RemoveUnwantedRows works the same way, but passing List changes depends on data.
Is there anyway I can have one routine?

C#

private static List<gosooeamount> RemoveUnwantedRows(List<gosooeamount> lstData)
{

    List<gosooeamount> lstfoundEmpty = null;
    lstfoundEmpty = lstData.FindAll(c =>
                    c.Rec1_Amount == "0" &&
                    c.Rec1_Amount == "0");
    if (lstfoundEmpty.Count > 0)
    {
        foreach (GOSOOEAmount lstItem in lstfoundEmpty)
        {
            GOSOOEAmount foundGOS = null;
            foundGOS = lstData.FirstOrDefault(c =>
                            c.GOS_Seq == lstItem.GOS_Seq &&
                            c.Rec1_Amount != "0" &&
                            c.Rec1_Amount != "0");
            if (foundGOS != null)
            {
                lstData.Remove(lstItem);
            }
        }

    }

    return lstData;
}

private static List<gosftepositions> RemoveUnwantedRows(List<gosftepositions> lstData)
{

    List<gosftepositions> lstfoundEmpty = null;
    lstfoundEmpty = lstData.FindAll(c =>
                    c.Rec1_Amount == "0" &&
                    c.Rec1_Amount == "0");
    if (lstfoundEmpty.Count > 0)
    {
        foreach (GOSFTEPositions lstItem in lstfoundEmpty)
        {
            GOSFTEPositions foundGOS = null;
            foundGOS = lstData.FirstOrDefault(c =>
                            c.GOS_Seq == lstItem.GOS_Seq &&
                            c.Rec1_Amount != "0" &&
                            c.Rec1_Amount != "0");
            if (foundGOS != null)
            {
                lstData.Remove(lstItem);
            }
        }

    }

    return lstData;

}

[Edit]Code block added[/Edit]

Posted 5-Dec-12 6:33am

SandhyaPillai

Updated 5-Dec-12 6:34am

Thomas Daniels

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

BC @ CV · Accepted Answer · 2012-12-05T07:02:00

Solution 1

Why not use a generic type with a common interface.

C#

private static List<T> RemoveUnwantedRows<T>(List<T> lstData)  where T: Igos
        {
            List<T> lstfoundEmpty = null;
            lstfoundEmpty = lstData.FindAll(c =>
                            c.Rec1_Amount == "0" &&
                            c.Rec1_Amount == "0");
            if (lstfoundEmpty.Count > 0)
            {
                foreach (T lstItem in lstfoundEmpty)
                {
                    T foundGOS = lstData.FirstOrDefault(c =>
                                    c.GOS_Seq == lstItem.GOS_Seq &&
                                    c.Rec1_Amount != "0" &&
                                    c.Rec1_Amount != "0");
                    if (foundGOS != null)
                    {
                        lstData.Remove(lstItem);
                    }
                }
            }
            return lstData;
        }

Posted 5-Dec-12 7:02am

BC @ CV

Comments

SandhyaPillai 5-Dec-12 13:32pm

I tried as follows, but how do u specify multiple ones for T?

private static List<t> RemoveUnwantedRows<t>(List<t> lstData) where T: GOSMOFAmount, GOSFTEPositions

BC @ CV 5-Dec-12 13:47pm

I don't know what you mean by, "multiple ones for T". You just create classes that inherit the interface and pass the type thusly:

RemoveUnwantedRows<gosooeamount>(lstData)

If you are unable to inherit the interface because the classes are in an API you didn't create; you can either create your own derived class that inherits the gosooeamount and gosftepositions classes along with the interface or you can check which type the function is processing and cast it to that type. I suppose you could also use reflection but that's a lot of work.

SandhyaPillai 5-Dec-12 14:10pm

Here is the scenario.
I created 2 classes as follows

public class GOSFTEPositions
{
public string GOS_Seq { get; set; }
public string Bud_Amount { get; set; }
public string Rec1_Amount { get; set; }
public string Rec2_Amount { get; set; }
public string Sequence { get; set; }
}

public class GOSMOFAmount
{
public string GOS_Seq { get; set; }
public string MOF_Code { get; set; }
public string Bud_Amount { get; set; }
public string Rec1_Amount { get; set; }
public string Rec2_Amount { get; set; }
public string Rider_Code { get; set; }
}

Then wrote a method but with different parameter
private static List<gosmofamount> RemoveUnwantedRows(List<gosmofamount> lstData)
private static List<gosftepositions> RemoveUnwantedRows(List<gosftepositions> lstData)

I may have to do the same with different List<t> too, hence looking for generic.
What would be the best way?

BC @ CV 5-Dec-12 14:23pm

since the two classes are your creation, that makes it easy. You just inherit the common interface (ref as Igos in my solution) and pass the class type you want the function to process as shown in my previous comment.

SandhyaPillai 5-Dec-12 15:11pm

can u give a code sample?

I created IGOS interface as follows
public interface IGOS{}

added inheritance to the classes
public class GOSMOFAmount :IGOS
public class GOSOOEAmount :IGOS

then defined following method
private static List<t> RemUnwantedRows<t>(List<t> lstData) where T: IGOS

But inside the method, when i do the following, it gives error
"T does not contain definition for Rec1_Amount "
lstfoundEmpty = lstData.FindAll(c =>
c.Rec1_Amount == "0" &&
c.Rec1_Amount == "0");

BC @ CV 5-Dec-12 15:29pm

That's because you have no properties defined in your interface. It sounds like you could benefit from learning more about object oriented programming. Read here.

SandhyaPillai 5-Dec-12 15:52pm

oops my mistake.......
modified interface as follows.....

public interface IGOS
{
string GOS_Seq { get; set; }
string Rec1_Amount { get; set; }
string Rec2_Amount { get; set; }
}
It works but I added only elements I need. Should I add all common elements from

GOSMOFAmount , GOSFTEPositions classsomething as follows: public interface IGOS { string GOS_Seq { get; set; } string Bud_Amount { get; set; } string Rec1_Amount { get; set; } string Rec2_Amount { get; set; } }

BC @ CV 5-Dec-12 16:01pm

Whether you add all common elements or not is a personal decision, but it wouldn't hurt to do so unless you might have other similar classes processed by this function in the future that wouldn't have those elements.

Often times interfaces are used to describe something a class should do, such as the .Net interface IEnumerable. You could change your interface to IRemovable and in that case it would seem highly appropriate to add only the methods and properties used by the RemUnwantedRows function to remove rows. You might even want to encapsulate the function itself into a base class that is inherited by the two classes.

SandhyaPillai 5-Dec-12 16:06pm

Thank you very much :)