crystal report date to date

Question

1.00/5 (1 vote)

See more:

Hello,
I've crystal report formal problem .I took the code from this website:
http://csharp.net-informations.com/crystal-reports/csharp-crystal-reports-date-to-date.htm[^]
,but when I do the formal it gave error string required.

[edit]Additional information copied from comment below:[/edit]
Also, I found this code and did some changes on it ,but the problem is it gives me all the date?

C#

private void button1_Click(object sender, EventArgs e)
        {
            string from_date = textBox1.Text ;
            string to_date = textBox2.Text;
            SqlConnection con=new SqlConnection (@"Data Source=.\Ahmed;Initial Catalog=Market;Integrated Security=True");
            String data = "SELECT * from Product  where dat>='"+from_date+"' and dat<='"+to_date+"'";
            con.Open();
            SqlDataAdapter ad1 = new SqlDataAdapter(data, con);
            DataSet ds1 = new DataSet();
            ad1.Fill(ds1);
            ReportDocument cr  = new ReportDocument();
            cr.Load(@"C:\Users\Ahmed\Documents\Visual Studio 2010\Projects\WindowsFormsApplication9\WindowsFormsApplication9\CrystalReport4.rpt");
 
            cr.SetDataSource(ds1.Tables["product"]);
            crystalReportViewer1.ReportSource = cr;
 
        }

Posted 1-Nov-12 7:03am

Member 8584763

Updated 1-Nov-12 7:43am

Nelek

v2

Add a Solution

Comments

Member 8584763 1-Nov-12 13:26pm

Also, I found this code and did some changes on it ,but the problem is it gives me all the date?
private void button1_Click(object sender, EventArgs e)
{
string from_date = textBox1.Text ;
string to_date = textBox2.Text;
SqlConnection con=new SqlConnection (@"Data Source=.\Ahmed;Initial Catalog=Market;Integrated Security=True");
String data = "SELECT * from Product where dat>='"+from_date+"' and dat<='"+to_date+"'";
con.Open();
SqlDataAdapter ad1 = new SqlDataAdapter(data, con);
DataSet ds1 = new DataSet();
ad1.Fill(ds1);
ReportDocument cr = new ReportDocument();
cr.Load(@"C:\Users\Ahmed\Documents\Visual Studio 2010\Projects\WindowsFormsApplication9\WindowsFormsApplication9\CrystalReport4.rpt");

cr.SetDataSource(ds1.Tables["product"]);
crystalReportViewer1.ReportSource = cr;

}

Sushil Mate 1-Nov-12 13:46pm

put the exception/error?

Member 8584763 1-Nov-12 13:52pm

Well, I think the problem in the strings it doesn't recognize them. Because dat type is date.

Sushil Mate 1-Nov-12 13:53pm

so you can convert the date type to string.

Member 8584763 1-Nov-12 13:56pm

how?

Sushil Mate 1-Nov-12 14:03pm

http://www.codeproject.com/Articles/14743/Easy-String-to-DateTime-DateTime-to-String-and-For

Member 8584763 1-Nov-12 14:06pm

the website talks about datetime my data type is date?

Member 8584763 1-Nov-12 14:29pm

I tried both of the methods, but it didn't work?

Member 8584763 1-Nov-12 15:13pm

where I took the code it was used like this
string from_date = Request.QueryString["fromdate"];
string to_date = Request.QueryString["todate"];

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Adam R Harris · Answer 1 · 2012-11-01T16:18:00

The problem is converting the string values to dates. To accomplish this you should use an actual SqlCommand and SqlParameters (to prevent SQL injection). You are also going to need to convert the values the user entered in a the text box to DateTime objects. You should also use Between in your WHERE clause instead of <>.

Your code should look similar to this:
*** Note: I just typed this into the browser so it probably wont compile ***

C#

private void button1_Click(object sender, EventArgs e)
        {
            string from_date = textBox1.Text ;
            string to_date = textBox2.Text;
            DataSet ds1 = new DataSet();
            ReportDocument cr  = new ReportDocument();

            using (SqlConnection con=new SqlConnection (@"Data Source=.\Ahmed;Initial Catalog=Market;Integrated Security=True")){
                String data = "SELECT * from Product  where dat BETWEEN @StartDate AND @EndDate";
                con.Open();
                using (SqlCommand cmd = new SqlCommand(data, conn))
                {
                    // you are going to need to parse these dates in their expected format
                    // Convert.ToDateTime has some overrides for that
                    // See below for some links for some reading
                    cmd.Parameters.Add(new SqlParameter("@StartDate", Convert.ToDateTime(from_date));
                   cmd.Parameters.Add(new SqlParameter("@EndDate", Convert.ToDateTime(to_date));
                   using (SqlDataAdapter ad1 = new SqlDataAdapter(cmd))
                   {
                      ad1.Fill(ds1);
                   }
                }
            }

            cr.Load(@"C:\Users\Ahmed\Documents\Visual Studio 2010\Projects\WindowsFormsApplication9\WindowsFormsApplication9\CrystalReport4.rpt");
            
            cr.SetDataSource(ds1.Tables["product"]);
            crystalReportViewer1.ReportSource = cr;
 
        }

You should probably read up on this stuff so here are some links:
SQL Between Operator[^]
SqlCommand Class[^]
SqlParameter Class[^]
C# using Statement[^]
DateTime.TryParseExact[^]
Convert.ToDateTime[^]