how to resolve this error

Question

0.00/5 (No votes)

See more:

SQL-Server-2008

C#

public class Service1 : IService1
    {

        string IService1.create(Class1 bobj)
        {
            string userid = string.Empty;

            SqlConnection con = new SqlConnection("conn");
            con.Open();
            SqlCommand cmd = new SqlCommand("sp_UserDetails", con);
            {
                cmd.CommandType = CommandType.StoredProcedure;
               
                cmd.Parameters.Add(new SqlParameter("UserName", bobj.UserName));
                cmd.Parameters.Add(new SqlParameter("Password", bobj.Password));
                cmd.Parameters.Add(new SqlParameter("Country", bobj.Country));
                cmd.Parameters.Add(new SqlParameter("Email", bobj.Country));
                cmd.ExecuteNonQuery();
            }
            return userid;
        }

i got this error: near the ExecutiveNonQuery "Procedure or function 'sp_UserDetails' expects parameter '@UserId', which was not supplied."

SQL

ALTER PROCEDURE [dbo].[sp_UserDetails]
(
    
    @UserName	nvarchar(100),
    @Password   nvarchar(50),
    @Country	nvarchar(50),
    @Email		nvarchar(100),
    @UserId		int OUTPUT
    
)
AS

INSERT INTO RegistrationTable
(
    UserName,
    Password,
    Country,
    Email
    
)

VALUES
(
    @UserName,
    @Password,
    @Email,
    @Country
    
)

SELECT
    @UserId = @@Identity

Posted 29-Oct-12 17:58pm

2011999

Updated 29-Oct-12 18:02pm

Manoj K Bhoir

v2

Add a Solution

4 solutions

Solution 1

Simple,your procedure requires '@UserId' parameter which is missing in the code. you need to add another parameter like below,

public class Service1 : IService1
    {
 
        string IService1.create(Class1 bobj)
        {
            string userid = string.Empty;
 
            SqlConnection con = new SqlConnection("conn");
            con.Open();
            SqlCommand cmd = new SqlCommand("sp_UserDetails", con);
            {
                cmd.CommandType = CommandType.StoredProcedure;
               
                cmd.Parameters.Add(new SqlParameter("@UserName", bobj.UserName));
                cmd.Parameters.Add(new SqlParameter("@Password", bobj.Password));
                cmd.Parameters.Add(new SqlParameter("@Country", bobj.Country));
                cmd.Parameters.Add(new SqlParameter("@Email", bobj.Email));
                cmd.Parameters.Add(new SqlParameter("@UserId", bobj.UserId));
                cmd.ExecuteNonQuery();
            }
            return userid;
        }

Posted 29-Oct-12 18:10pm

Street Racers

Updated 1-Nov-12 18:24pm

v2

Solution 3

Hey man you must have to write your code as follows.
You should have to write '@' prefix of parameter name.

C#

public class Service1 : IService1
    {
 
        string IService1.create(Class1 bobj)
        {
            string userid = string.Empty;
 
            SqlConnection con = new SqlConnection("conn");
            con.Open();
            SqlCommand cmd = new SqlCommand("sp_UserDetails", con);
            {
                cmd.CommandType = CommandType.StoredProcedure;
               
                cmd.Parameters.Add(new SqlParameter("@UserName", bobj.UserName));
                cmd.Parameters.Add(new SqlParameter("@Password", bobj.Password));
                cmd.Parameters.Add(new SqlParameter("@Country", bobj.Country));
                cmd.Parameters.Add(new SqlParameter("@Email", bobj.Country));
                cmd.ExecuteNonQuery();
            }
            return userid;
        }

Posted 29-Oct-12 22:09pm

BK 4 code

Updated 30-Oct-12 21:08pm

v3

Solution 4

Hi.. you have an out parameter to get the user id to WCF service class. So you need to add UserId parameter to the command object as an output parameter. After calling the cmd.ExecuteNonQuery(), we need to get the value of out parameter of the stored procedure. See this code block

 string userid = string.Empty;

 SqlConnection con = new SqlConnection("conn");
 con.Open();
 SqlCommand cmd = new SqlCommand
 {
     CommandText = "sp_UserDetails",
     Connection = con,
     CommandType = CommandType.StoredProcedure
 };

SqlParameter[] objSqlParameters = new SqlParameter[]
      {
          new SqlParameter("UserName",bobj.UserName),
          new SqlParameter("Password",bobj.Password),
          new SqlParameter("Country",bobj.Country),
          new SqlParameter("Email",bobj.Email),
          new SqlParameter("@UserId",SqlDbType.Int)
          {
             Direction = ParameterDirection.OutPut
          }
      }
 try
{
 con.Open();
 cmd.ExecuteNonQuery();

 userid = cmd.Parameters["@UserId"].Value;
 return userid;
 }
 catch(Exception ex)
 {
   //log your exception
 }
 finally
 {
  con.Close();
 }

Thank you

Posted 1-Nov-12 0:49am

damodara naidu betha

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Manoj K Bhoir** · Accepted Answer · 2012-10-29T18:18:00

As Per the Above Code You Have To Pass 5 Parameters While Executing the Procedure

1 : UserName
2 : Password 
3 : Country
4 : Email
5 : UserId

In Your C# Code Your are Passing Only 4 Parameters while Executing the Procedure See the Below Code :

C#

SqlConnection con = new SqlConnection("conn");
con.Open();
SqlCommand cmd = new SqlCommand("sp_UserDetails", con);
{
    cmd.CommandType = CommandType.StoredProcedure;

    cmd.Parameters.Add(new SqlParameter("UserName", bobj.UserName));
    cmd.Parameters.Add(new SqlParameter("Password", bobj.Password));
    cmd.Parameters.Add(new SqlParameter("Country", bobj.Country));
    cmd.Parameters.Add(new SqlParameter("Email", bobj.Email));
    cmd.Parameters.Add(new SqlParameter("UserId", bobj.UserId));
    cmd.ExecuteNonQuery();
}

Or Else Remove the UserID Parameter From Your Procedure If Not Required.

SQL

ALTER PROCEDURE [dbo].[sp_UserDetails]
(
    
    @UserName	nvarchar(100),
    @Password   nvarchar(50),
    @Country	nvarchar(50),
    @Email      nvarchar(100)
    
)
AS
 
INSERT INTO RegistrationTable
(
    UserName,
    Password,
    Country,
    Email
    
)
 
VALUES
(
    @UserName,
    @Password,
    @Email,
    @Country
    
)
 
SELECT
    @@Identity